Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Appropriate Page with Search Bar and Filters to "View More Hackathons" Button and Update Hackathons Content #407

Closed
wants to merge 15 commits into from

Conversation

Nishitbaria
Copy link
Contributor

Related Issue

The "View More Hackathons" button in the hackathons section of the website currently reloads the page upon clicking, instead of navigating to a designated page or section displaying additional hackathons. This results in a poor user experience and does not provide users with the expected functionality to explore more hackathons. Additionally, the hackathons section needs to be updated with appropriate hackathon content to ensure accurate and up-to-date information.

Closes: [#353 ]

Description of Changes

  • Modified the route and created page for the "View More Hackathons" button to redirect users to the designated page or section.
  • The hackathons page contain search bar,filter and saving hackathon option
  • Added new hackathon content to the hackathons section, ensuring accuracy and relevance.

Checklist:

  • My code adheres to the established style guidelines of this project.
  • I have conducted a self-review of my code.
  • I have included comments in areas that may be difficult to understand.
  • I have made corresponding updates to the project documentation.
  • My changes have not introduced any new warnings.

Screenshots

Original Updated
Original screenshot Updated screenshot WhatsApp Image 2023-06-21 at 15 12 04

Please feel free to suggest changes

@vercel
Copy link

vercel bot commented Jun 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
grabtern-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2023 6:00am

@github-actions
Copy link

Thank you, @Nishitbaria, for creating this pull request and contributing to GitHub-ReadMe!
Our review team will thoroughly review the pull request and will reach out to you soon!
Please make sure you have marked all the completed tasks as done.
We appreciate your patience and contribution!

@github-actions github-actions bot added the gssoc23 This is label for GirlScript Summer of Code 2023 label Jun 21, 2023
@anmode
Copy link
Owner

anmode commented Jun 21, 2023

Please rmv that background. It is degrading the User experience.
see the UI formity

@Nishitbaria
Copy link
Contributor Author

Please review and merge pr with appropriate level and tag

@anmode
Copy link
Owner

anmode commented Jun 22, 2023

Again same thing!
Background not needed and it deforming the UI. Please this is not the way to do.
You should see UI see other parts of website you will get to know where you are lacking.

@Nishitbaria
Copy link
Contributor Author

Nishitbaria commented Jun 22, 2023

Again same thing! Background not needed and it deforming the UI. Please this is not the way to do. You should see UI see other parts of website you will get to know where you are lacking.

I have made changes Please check

@anmode
Copy link
Owner

anmode commented Jun 22, 2023

build is failing

@Nishitbaria
Copy link
Contributor Author

I deplyed my fork it is deployed 👍🏻link please check

@anmode
Copy link
Owner

anmode commented Jun 22, 2023

Okay @Nishitbaria I do want your work to get wasted here is what you can do:

  1. I see hackathon card on homepage their sizes are differing please fix that
  2. As you create page: Just please same card there but a lot more ( if you can fetch hackthon details from any api if available that would be cool )

Please Try to have UI formity as i see you used a colorful heading in the hackathon page it is not good .

And please fix build here as github tries to merge your pR and then show error if I merge without test pass the error will be merged and will cause error in repo

@Nishitbaria
Copy link
Contributor Author

Please review

@anmode
Copy link
Owner

anmode commented Jun 23, 2023

Same:

  1. When I go to hackathon page ( Card should same as they are in home page same design)
  2. when i click on filter ( different UI - colorful links)
  3. When click on bookmark a text Remove which in diff UI

The thing is UI is not Uniform. please look into it.

@Nishitbaria
Copy link
Contributor Author

Nishitbaria commented Jun 23, 2023

So lets clarify : 1. you dont want description of hackathons on hacakthon page, you want formal ui,you dont want tooltip on bookmark ? please confirm and explain clearly 3rd point

@anmode
Copy link
Owner

anmode commented Jun 23, 2023

My point is!
As we can show limited hackathons on the home page... but if the user wants to view more there should be a page where we have hackathon cards and we can pass data from the JSON file
The thing is to maintain the UI for the card as same shown on the home page.

@Nishitbaria
Copy link
Contributor Author

My point is! As we can show limited hackathons on the home page... but if the user wants to view more there should be a page where we have hackathon cards and we can pass data from the JSON file The thing is to maintain the UI for the card as same shown on the home page.

means you dont want description of hackathon on hackathon page

@anmode
Copy link
Owner

anmode commented Jun 23, 2023

My point is! As we can show limited hackathons on the home page... but if the user wants to view more there should be a page where we have hackathon cards and we can pass data from the JSON file The thing is to maintain the UI for the card as same shown on the home page.

means you dont want description of hackathon on hackathon page

yess! we will link card to respective site

Nishitbaria and others added 2 commits June 24, 2023 16:43
@Nishitbaria
Copy link
Contributor Author

Nishitbaria commented Jun 25, 2023

@anmode I have made a new final pull request for this please review it #436

@anmode anmode closed this Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc23 This is label for GirlScript Summer of Code 2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants