Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace Gluten.Buffer implementation #67

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

anmonteiro
Copy link
Owner

@anmonteiro anmonteiro commented Oct 15, 2023

  • gets rid of the ke dependency
  • goes back to using the simpler Buffer implementation we had before, which seems to have a small edge in micro-benchmarks

benched with the help of chrstntdd/ocaml_http#2

@anmonteiro anmonteiro merged commit ce5cbe3 into master Oct 16, 2023
3 checks passed
@anmonteiro anmonteiro deleted the anmonteiro/faster-buffer branch October 16, 2023 00:33
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Oct 26, 2023
CHANGES:

- gluten-eio: require `~sw:Eio.Switch.t` argument and fail the switch when loop
  raises an exception ([anmonteiro/gluten#61](anmonteiro/gluten#61))
- gluten-eio: handle peer disconnects
  ([anmonteiro/gluten#60](anmonteiro/gluten#60))
- gluten: replace `Gluten.Buffer` implementation and drop the `Ke` dependency
  ([anmonteiro/gluten#67](anmonteiro/gluten#67))
- gluten-eio: adapt to Eio v0.12 ([anmonteiro/gluten#66](anmonteiro/gluten#66)
- gluten-eio: don't fail switches in the I/O loop([anmonteiro/gluten#70](anmonteiro/gluten#70)
- gluten-eio: open up #Eio.Flow.two_way ([anmonteiro/gluten#62](anmonteiro/gluten#62)
- gluten-async: async-tls compilation error when using tls-async package ([anmonteiro/gluten#63](anmonteiro/gluten#63))
- gluten-eio, gluten-async, gluten-lwt, gluten-lwt-unix: refactor: unwrap Gluten.Buffer.put in favor of exceptions ([anmonteiro/gluten#58](anmonteiro/gluten#58))
nberth pushed a commit to nberth/opam-repository that referenced this pull request Jun 18, 2024
CHANGES:

- gluten-eio: require `~sw:Eio.Switch.t` argument and fail the switch when loop
  raises an exception ([anmonteiro/gluten#61](anmonteiro/gluten#61))
- gluten-eio: handle peer disconnects
  ([anmonteiro/gluten#60](anmonteiro/gluten#60))
- gluten: replace `Gluten.Buffer` implementation and drop the `Ke` dependency
  ([anmonteiro/gluten#67](anmonteiro/gluten#67))
- gluten-eio: adapt to Eio v0.12 ([anmonteiro/gluten#66](anmonteiro/gluten#66)
- gluten-eio: don't fail switches in the I/O loop([anmonteiro/gluten#70](anmonteiro/gluten#70)
- gluten-eio: open up #Eio.Flow.two_way ([anmonteiro/gluten#62](anmonteiro/gluten#62)
- gluten-async: async-tls compilation error when using tls-async package ([anmonteiro/gluten#63](anmonteiro/gluten#63))
- gluten-eio, gluten-async, gluten-lwt, gluten-lwt-unix: refactor: unwrap Gluten.Buffer.put in favor of exceptions ([anmonteiro/gluten#58](anmonteiro/gluten#58))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant