Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move streaming flush out of body #142

Merged
merged 2 commits into from
Sep 27, 2020
Merged

Move streaming flush out of body #142

merged 2 commits into from
Sep 27, 2020

Conversation

anmonteiro
Copy link
Owner

first part of #141, including a failing test

@anmonteiro anmonteiro force-pushed the move-streaming-flush-out-of-body branch 3 times, most recently from 5b61aaa to c2f2a7d Compare September 27, 2020 05:53
@anmonteiro
Copy link
Owner Author

anmonteiro commented Sep 27, 2020 •
edited
Loading

cc @blandinw this is the first part of #141 with the fix for the bug you found + tests.

I preserved the authorship of your commit.

@anmonteiro anmonteiro force-pushed the move-streaming-flush-out-of-body branch from c2f2a7d to 13fc069 Compare September 27, 2020 05:54
@blandinw
Copy link
Contributor

Thanks for the quick turnaround, I rebased #141 on this branch!
Also, I think you should just say "thanks blandinw" in the CHANGES.md file since really, you wrote the fix and the test 😅

@anmonteiro anmonteiro force-pushed the move-streaming-flush-out-of-body branch from 13fc069 to a71ebb7 Compare September 27, 2020 23:23
@anmonteiro anmonteiro merged commit b126bb2 into master Sep 27, 2020
@anmonteiro anmonteiro deleted the move-streaming-flush-out-of-body branch September 27, 2020 23:25
@anmonteiro anmonteiro mentioned this pull request Apr 12, 2021
Merged
anmonteiro added a commit to anmonteiro/opam-repository that referenced this pull request Apr 12, 2021
@anmonteiro
[new release] hpack, h2, h2-mirage, h2-lwt, h2-lwt-unix and h2-async …
d3dda70 
…(0.8.0)

CHANGES:

- h2: scheduler: fix bug that caused zero length DATA frames not to be sent if
  there were no flow-control credits
  ([anmonteiro/ocaml-h2#142](anmonteiro/ocaml-h2#142)) -- reported  by
  [@blandinw](https://github.com/blandinw)
- h2,h2-lwt,h2-lwt-unix,h2-async,h2-mirage Add `trailers_handler` to
  `Connection.request` ([anmonteiro/ocaml-h2#146](anmonteiro/ocaml-h2#146))
- h2: client / server: fix a security issue that allowed a malicious peer to
  make h2 allocate as much as it wanted
  ([anmonteiro/ocaml-h2#149](anmonteiro/ocaml-h2#149))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anmonteiro @blandinw