Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Klipper Estimator does weird post-processing things with Linear Advance in Cura #15

Closed
psiberfunk opened this issue Apr 7, 2022 · 3 comments

Comments

@psiberfunk
Copy link

As the title says, I get a weird diff when I compare the pre-processed and the post-processed files with klipper estimator when using in conjunction with FieldOfView's Linear Advance plugin. In particular, it seems like Klipper estimator is moving around the order of the linear advance command in an odd fashion according to this diff at the beginning of the file. Is there a reason why?

image

@psiberfunk
Copy link
Author

psiberfunk commented Apr 7, 2022

Note that this behavior is "less weird" when first generating a file without klipper estimator being used via the "inline" cura post-processing interface... When this is done instead (produce GCODE, still with linear advance plugin, then post-process via the command line), the file looks different, and only the times are changed instead, and only a line added at the very end noting it was post-processed.

This command-line behavior is what I expected.. but it seems that the Cura-helper compatibility script may get executed in such a way as to create the odd behavior above .. which is a bit odd..

@dalegaard
Copy link
Collaborator

Hi @psiberfunk

There's a very real possibility that the Cura script is bugged. I don't use Cura myself, and wrote the script over a few hours to help. It may have weird interactions with other plugins.

Sadly I'm not really able to debug this much myself, so I hope someone else is willing to take a look at it. From your second comment it sounds like the bug is definitely in the post processing script and not klipper_estimator itself.

Best regards,
Lasse

@dalegaard
Copy link
Collaborator

Hi @psiberfunk

I'll close this for now. If someone has time to look in to the issue later on, we can re-open :)

Best regards,
Lasse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants