This repository has been archived by the owner on Apr 2, 2023. It is now read-only.
#193 added removeHandler method #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now user can pass optional handler to the method to remove specific handler, otherwise it removes all such handlers of matching type.
In case if screen had scrollbar (expecially on Chrome browser), annotations were getting displaced by scroll positions.
|
That's awesome! Many thanks! |
|
so cool ! |
|
There is no removeHandler method in the official web version？so, How to compile the source code？please |
|
@aaaxiu you can compile by following this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 193
Added a removeHandler method to Annotorious to be able to remove handler methods like 'onAnnotationCreated'.