-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate voting form directly #135
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so much an issue, but I'm not sure if we should also keep
!form
around "just in case" for now.
Mmm, with the ability to test the form beforehand I'd be surprised if we needed to regenerate after running !list
publicly. Even then we could just re-run !list
(and delete any audio files that were posted in the meantime).
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the slow turn-around times. This LGTM!
Closes #12. Automatically generate and send voting form on
!list
.Also added an
!image
to load an image to be placed at the front of the voting form. A loaded image does not get unset automatically when a form is generated, but it can be cleared manually with!image clear
. To set an image use either!image <url>
or run!image
with an image attachment.Also added another option
full
to!list
. When eitherfull
is passed to!list
or the channel the command was issued in is the same as the target channel, the tracklist will be pinned and the form will be generated (and pinned). This is so form generated can be tested before the show.Check the diffs on
README.md
for other user-facing changes.I also added the 👍 and 🛑 emoji to
config.py
instead of locally tobust.py
since they are also used in!image
.KNOWN ISSUES
!image
is used, the attachment/url is not scanned at all for validity until the Form is generated. The Form is generated such that if the image is invalid, then generation will still work but without the image.BUSTY_GOOGLE_FORM_FOLDER
is invalid. The move command just silently fails, though the form is still generated.!list
cache). Would be nice to save state to disk when set so that we can set the bust image at any point and restart/update busty in the meantime.!form
around "just in case" for now.I'm fine merging with these issues, but 1 & 2 & 3 should have bugs created on merging if this is the case.