apps: include git describe version string
#733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juped
force-pushed
the
ray/git-describe-version
branch
from
c3f3043
to
4f66715
Compare
|
Addresses #665, albeit correctly (one cannot include branch names in version strings) |
Include a version string from `git describe` to use in --version output, falling back on the crate version if no git repository is found.
juped
added a commit
that referenced
this pull request
Jan 10, 2022
* ray/git-describe-version: apps: include `git describe` version string
juped
added a commit
that referenced
this pull request
Jan 10, 2022
* ray/git-describe-version: apps: include `git describe` version string
juped
added a commit
that referenced
this pull request
Jan 10, 2022
* ray/git-describe-version: apps: include `git describe` version string
juped
force-pushed
the
ray/git-describe-version
branch
from
4f66715
to
c84f65a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a version string from
git describeto use in --versionoutput, falling back on the crate version if no git repository is
found.
This doesn't actually work, because Cargo is bad and there's no way to force build.rs to rerun. Forcing it to rerun on .git changes might seem to work, but it doesn't - we may be in a worktree and .git may be a file pointing to the main repository. Better approaches welcome.