Support parallel module compilation in justfile #2729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcadman
force-pushed
the
just-parallel-modules
branch
from
c5c66d2
to
78ba49f
Compare
lukaszcz
force-pushed
the
just-parallel-modules
branch
from
78ba49f
to
530bdbe
Compare
This option is not set if `disableParallel` is set. You can configure the argument to `-j` by setting `numParallelJobs`.
paulcadman
force-pushed
the
just-parallel-modules
branch
from
530bdbe
to
0b5d628
Compare
janmasrovira
pushed a commit
that referenced
this pull request
Apr 18, 2024
This PR changes the CI build to use the justfile instead of the Makefile to run builds and tests. CI builds now take advantage of parallel module builds from #2729. In order support this the runtime build target in the justfile now supports `runtimeCcArg` and `runtimeLibtoolArg` so that the `CC` and `LIBTOOL` Makefile argument can be set. This is required for the macOS build. In addition this PR upgrades the stack setup step action. Previously the stack build flags included `--fast` which meant the whole project was rebuilt in the `test` step, this has also been fixed. Overall this speeds up the CI: * Linux now takes 30mins (from 40mins) * macOS now takes 60mins (from 80mins)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @janmasrovira for figuring out that the stack
--ghc-options=-jflag enables parallel module compilation in GHC.This PR adds support for this in the project justfile.
You can configure the argument to
-jusing thenumParallelJobsoption, for example:If
numParallelJobsis not set then-jis passed with no arguments in--ghc-options(this is equivalent to passing the number of cpus of the machine.) and is passed with the number of cpus of the machine for the stack-joption (the stack-joption requires an argument).The
numParallelJobsoption also sets the argument to the stack-joption.To disable build parallelism set the
disableParallelflag: