Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoS - rename validator "total_deltas" to "total_stake" #158

Closed
tzemanovic opened this issue Jul 6, 2022 · 1 comment · Fixed by #740
Closed

PoS - rename validator "total_deltas" to "total_stake" #158

tzemanovic opened this issue Jul 6, 2022 · 1 comment · Fixed by #740
Assignees
@brentstone
Labels
PoS
Milestone
0.15

Comments

@tzemanovic
Copy link
Member

No description provided.

@tzemanovic tzemanovic added the PoS label Jul 6, 2022
@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@brentstone
Copy link
Collaborator

I am in favor of keeping the name total_deltas but instead renaming variables in code to accurately indicate when something is actually the total stake, such as in:

total_stake = total_deltas.get(epoch)

This is how I have been proceeding so far in #388. Alternatively, we could also rename the get method of EpochedDelta to something like get_sum, since this is what is happening more accurately.

@brentstone brentstone self-assigned this Sep 20, 2022
@cwgoes cwgoes added this to the 0.15 milestone Jan 16, 2023
@tzemanovic tzemanovic mentioned this issue Feb 3, 2023
Merged
@juped juped closed this as completed in #740 Feb 7, 2023
@github-project-automation github-project-automation bot moved this from Todo to Tested in Devnet in Namada-Old Feb 7, 2023
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
@mateuszjasiuk
feat: update namada to 0.11.0 (anoma#158)
a43ce14 
* fix: shared build

* feat: update wasms

* refactor: cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brentstone brentstone

Labels
PoS
Projects
No open projects
Namada-Old
Status: Tested in Devnet
Milestone
0.15
Development

Successfully merging a pull request may close this issue.

PoS: lazy map epoched data anoma/namada
3 participants
@tzemanovic @cwgoes @brentstone