Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the Bridge pool fees to be payed in more token types #1704

Closed
7 tasks done
sug0 opened this issue Jul 11, 2023 · 2 comments · Fixed by #1795
Closed
7 tasks done

Allow the Bridge pool fees to be payed in more token types #1704

sug0 opened this issue Jul 11, 2023 · 2 comments · Fixed by #1795
Assignees
Labels
enhancement New feature or request ethereum-bridge has-a-pr The issue has been solved by a PR that has yet to be merged

Comments

@sug0
Copy link
Contributor

sug0 commented Jul 11, 2023

Allow the Ethereum Bridge pool fees to be payed in more token types. This feature depends on #1693.

Associated tasks:

  • Change the Bridge pool VP logic to accept more gas token types, and check their escrowed amounts
  • Determine how to remove from the appropriate Bridge pool escrow token address (we're currently hardcoded to NAM)
  • Change CLI arguments
  • Fix build_bridge_pool_tx (must use fee token addr obtained from args)
  • Test paying gas fees in NUTs is not possible
  • Test paying gas fees with wrapped NAM (NUTs or ERC20s) is not possible
  • Add tests checking fee token types other than NAM in the Bridge pool

Relevant CLI arguments:

      --fee-amount <fee-amount>
          The amount of NAM you wish to pay to have this transfer relayed to Ethereum.
      --fee-payer <fee-payer>
          The Namada address of the account paying the fee.
      --gas-amount <gas-amount>
          The amount being paid for the inclusion of this transaction
      --gas-token <gas-token>
          The token for paying the gas
@sug0
Copy link
Contributor Author

sug0 commented Jul 11, 2023

Should we allow the Bridge pool fees to be payed in more token types, other than NAM?
cc @batconjurer

EDIT: Updated the issue's body. Originally it was just a question.

@batconjurer
Copy link
Member

Yes, we should

@sug0 sug0 self-assigned this Aug 8, 2023
@sug0 sug0 added the has-a-pr The issue has been solved by a PR that has yet to be merged label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ethereum-bridge has-a-pr The issue has been solved by a PR that has yet to be merged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants