Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement reward products #499

Closed
Tracked by #340
brentstone opened this issue Sep 21, 2022 · 3 comments
Closed
Tracked by #340

Implement reward products #499

brentstone opened this issue Sep 21, 2022 · 3 comments
Assignees
Labels

Comments

@brentstone
Copy link
Collaborator

brentstone commented Sep 21, 2022

Implement the reward product mechanism described in the F1 Fee distribution such that rewards are effectively auto-rebonded.

@brentstone brentstone added the PoS label Sep 21, 2022
@brentstone brentstone self-assigned this Sep 21, 2022
@brentstone
Copy link
Collaborator Author

Something to figure out:

If the rewards are auto-rebonded, then how should the voting power and total deltas be updated? Should the total and validator deltas be updated in place in accordance with the reward products? Should there be a way to ensure that the increase in stake due to rewards only affects the voting power starting at the pipeline_offset? When voting power is calculated, should we consult the reward products as well in addition to checking the total and validator deltas?

@tzemanovic
Copy link
Member

We can probably take the same approach as slashing for rewards, which is to update the validators' total_deltas with calculated rewards at pipeline offset (eagerly) when it's calculated and individual bonds amount only when those bond are being withdrawn (lazily)

@brentstone
Copy link
Collaborator Author

Implemented in #714

phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
* feat: add annoucement link

* feat: adding announcement url to SidebarPage

---------

Co-authored-by: Pedro Rezende <xpedrorezende@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants