Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anoma commands should hint to join a chain on first use rather than panicking #97

Closed
james-chf opened this issue Apr 12, 2022 · 0 comments · Fixed by #291
Closed

anoma commands should hint to join a chain on first use rather than panicking #97

james-chf opened this issue Apr 12, 2022 · 0 comments · Fixed by #291
Labels
bug Something isn't working client good first issue Good for newcomers ledger UX wallet

Comments

@james-chf
Copy link
Contributor

james-chf commented Apr 12, 2022

When using binaries that weren't compiled with the dev feature enabled (e.g. prebuilt release binaries), common commands like anoma client balance, anoma ledger, anoma wallet address list, etc. produce a panic about not finding a file. e.g.

~/Code/heliax/anoma/internal-testnet-n1
mbp> anoma wallet address list 
No wallet found at ".anoma/anoma-internal.000000000000000/wallet.toml". Creating a new one.
The application panicked (crashed).
Message:  called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
Location: apps/src/lib/config/genesis.rs:527

Backtrace omitted.
Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

We should instead exit cleanly with a hint to the user to join a chain first (i.e. using anoma client utils join-network). In the docs we would indicate this but users may try running commands anyway.

@james-chf james-chf added bug Something isn't working good first issue Good for newcomers labels Apr 12, 2022
@james-chf james-chf changed the title anoma commands should hint to join-network anoma commands should hint to join a testnet on first use rather than panicking Apr 12, 2022
@tzemanovic tzemanovic added the UX label Apr 13, 2022
@tzemanovic tzemanovic transferred this issue from anoma/anoma Jul 7, 2022
@james-chf james-chf changed the title anoma commands should hint to join a testnet on first use rather than panicking anoma commands should hint to join a chain on first use rather than panicking Jul 27, 2022
phy-chain pushed a commit to phy-chain/namada that referenced this issue Mar 1, 2024
* Begin setting up KeyRing & accounts storage

* Adding a simple typed state class to keyring

* Address helper to obtain ImplicitAddress, cargo update

* Continue hooking up KeyRing to services

* Fix broken imports, confirm message works in popup

* Adding msg type for fetch generated mnemonic, update tests

* Beginning components package; get styled-components with theme working

* Disable devtool sourcemapping, add plugin for extension reloading (all browsers)

* Properly include svg assets, port additional components into shared
package

* Fix issue on reloader plugin

* fix module resolution, clean up imports

* Remove unnecessary assignment

* Consolidate types from Keplr into our own

* Validate mnemonic phrase before storing, better error handling in wasm

* Minor clean up, better type State class so as not to instantiate
directly

* Adding mnemonic/password creation screens, added README for types

* Split set-up flow into new tab for initial account

* Begin wiring up account derivation in service, generate implicit address
to store and return

* Add account derivation to completion process, load and display accounts

* Better error-handling, add user feedback on account creation

* Adding AccountListing components

* Clean up configs, layout, fixed bug in key storage

* Improved naming conventions, add implementation for scrypt, tests

* Implement optional custom Scrypt params

* Updated documentation

* Add aes dependency, being basic implementation

* KeyRing state is no longer duplicated, storage is only source of truth

* Add icon for copy to clipboard, additional styling, update styled config

* description -> alias to match cli, clean up

* Adding UI for adding a new derived account with basic validation

* Fix bug where alias is not being saved

* Add "alias" as a field during setup

* Updating for consistency, rough pass at styling derivation form

* Move path items to number, validate inputs, set primes appropriately

* Begin implementing kdf derived key as bytes

* Fix naming on file extension, begin components for password auth

* Add basic login/logout functionality, hook up to service backend

* Clean up effects, check keyring status on auth

* Fix minor bug when locking/unlocking wallet. Switch to numeric input

* Fix sourcemap warning, reuse lock button wrapper, minor style

* Update kdf libs for password hashing, tests, serializing params to
JsValue

* Add serializable struct and associated tests (params + bytes)

* Fix naming convention, create storage type containing params

* Moving storage updates to separate PR

* Adding support for argon2 and scrypt pbkdf hashing

* Cover Scrypt in jest tests

* Clean up

* Remove unused dependencies in this branch

* 2 more dependencies that are unneeded

* Adding dependencies

* Clean up

* Add serialize to key+params (argon2), add tests

* Fix for Cargo

* Improve custom params, add salt as an option

* Initial implementation of AES+Argon2 with related tests

* Clarify naming in jest test

* Update scrypt to accept salt, optional params, similar tests with AES

* Clean up

* Add missing test for scrypt with provided salt, clean up

* Clean up Rust lib, begin to implement encrypt/decrypt in KeyRing

* Add simple Rng mod for generating random bytes

* Touch up TS types

* clean up tests

* Connect KeyRing instance to new storage types, update UI

* Minor styling, match account hierarchy to other wallets

* Improve naming conventions, comments, updated for consistency

* Couple minor fixes that slipped through the cracks

* Minor updates per feedback

* Minor updates per PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client good first issue Good for newcomers ledger UX wallet
Projects
No open projects
Status: Tested in Devnet
2 participants