Rename '--ledger-address' to '--node' #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's more common to refer to the cli option that connects to a fullnode as '--node'.
tzemanovic
reviewed
Feb 15, 2023
tzemanovic
approved these changes
Feb 15, 2023
tzemanovic
added a commit
that referenced
this pull request
Apr 6, 2023
* adrian/rename_ledgeraddress_to_node: changelog: add #1031 cli: add "ledger-address" alias for "node" arg to backwards compat run formatter Rename '--ledger-address' to '--node'
Closed
|
I can't review this because it's by me, but disapproved: we shouldn't ever rename commands like this; you have to allow both to be valid |
I’ve added 345a955 for this, so it should be backwards compatible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and reopened version of #1000, which was merged erroneously.