Allow the ledger to halt/suspend at a pre-configured height. #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…remain responsive
sug0
requested changes
Mar 1, 2023
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
…into bat/feature/stop-at-height
sug0
previously approved these changes
Mar 2, 2023
tzemanovic
reviewed
Mar 7, 2023
tzemanovic
reviewed
Mar 7, 2023
tzemanovic
reviewed
Mar 7, 2023
tzemanovic
reviewed
Mar 7, 2023
tzemanovic
previously approved these changes
Mar 8, 2023
juped
previously approved these changes
Apr 6, 2023
tzemanovic
previously approved these changes
Apr 11, 2023
tzemanovic
approved these changes
Apr 11, 2023
tzemanovic
added a commit
that referenced
this pull request
Apr 11, 2023
* bat/feature/stop-at-height: changelog: #1189 [fix]: Suspending and halting now works for syncing the chain [fix]: Addressing review comments [fix]: Removed double boxing of futures Update apps/src/lib/node/ledger/shims/abcipp_shim.rs [feat]: Added e2e tests covering the new features [feat]: Fixed graceful shutdown after suspension. Added more logging [temp]: Trying to shutdown ledger gracefully post-suspension [fix]: Fixed a lifetimes issue in the futures [feat]: Refactoring suspend to allow queries other than consensus to remain responsive [feat]: Add commands to halt/suspend chain at specified block height
Closed
bengtlofgren
pushed a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new ledger sub-command:
run-until. Then, at the provided block height, the node will either halt or suspend. If the chain is suspended, only the consensus connection is suspended. This means that the node can still be queried. This is useful for debugging purposes.Halting the chain at a given block height, is useful for hardforking and also for debugging.