Prune Merkle tree stores #1237
Merged
Prune Merkle tree stores #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juped
approved these changes
Mar 22, 2023
core/src/ledger/storage/mod.rs
Outdated
| .block | ||
| .pred_epochs | ||
| .get_start_height_of_epoch(epoch.prev()) | ||
| { |
There was a problem hiding this comment.
I wonder if it might not be better to have the interface prune by epoch rather than block? i.e., prune_merkle_tree_stores(10) to prune all of epoch 10's blocks (moving the logic in get_start_height_of_epoch() to prune_merkle_tree_stores()).
There was a problem hiding this comment.
It sounds better. Thanks!
juped
added a commit
that referenced
this pull request
Mar 23, 2023
…into maint-0.14 * namada/yuji/prune_tree_stores: DB prune function given an epoch prune older merkle tree stores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1113
Prune the Merkle tree stores at a height: The height is the starting height of the previous epoch before the epoch including the oldest query height (= last_committed_height -
storage_read_post_hegiht_limit).The tree stores of the epoch might be used for rebuilding the tree stores at a query height. That's why we can prune the stores of the previous epoch.
I want to add the batch of these deletes into other batches in a future PR.