Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the tendermint binary ref to cometbft #1476

Merged
merged 2 commits into from
Jun 17, 2023
Merged

Change the tendermint binary ref to cometbft #1476

merged 2 commits into from
Jun 17, 2023

Conversation

bengtlofgren
Copy link
Contributor

No description provided.

@bengtlofgren bengtlofgren marked this pull request as ready for review May 25, 2023 16:53
@bengtlofgren bengtlofgren changed the title weeeeehooooo Change the tendermint binary ref to cometbft May 25, 2023
@bengtlofgren
Copy link
Contributor Author

pls build wasm

@bengtlofgren
Copy link
Contributor Author

pls update wasm

@adrianbrink
Copy link
Member

I'm closing #1454 in favor of this. #1454 proves that cometbft works in practice and this PR can figure out the practical changes needed to make it work

@adrianbrink adrianbrink mentioned this pull request May 30, 2023
Closed
@tzemanovic
Copy link
Member

I just force pushed to fix make fmt

tzemanovic added a commit that referenced this pull request Jun 5, 2023
@tzemanovic
changelog: add #1476
7d8c897
tzemanovic
tzemanovic previously approved these changes Jun 5, 2023
View reviewed changes
@bengtlofgren
Copy link
Contributor Author

Screenshot 2023-06-14 at 14 46 29

Fraccaman added a commit that referenced this pull request Jun 15, 2023
@Fraccaman
Merge branch 'origin/bengt/cometbft-correct' (#1476)
aa7162b 
* origin/bengt/cometbft-correct:
  changelog: add #1476
  ci: use comet binaries
  attended Tomas's comments
  [ci] wasm checksums update
  just wasm
  fixing e2e tests@
  weeeeehooooo
@Fraccaman Fraccaman mentioned this pull request Jun 15, 2023
Closed
Fraccaman added a commit that referenced this pull request Jun 15, 2023
@Fraccaman
Merge branch 'origin/bengt/cometbft-correct' (#1476)
8166655 
* origin/bengt/cometbft-correct:
  feat: switch tendermint references to cometbft
@Fraccaman Fraccaman mentioned this pull request Jun 15, 2023
Closed
Fraccaman added a commit that referenced this pull request Jun 15, 2023
@Fraccaman
Merge branch 'origin/bengt/cometbft-correct' (#1476)
864ff37 
* origin/bengt/cometbft-correct:
  ci: restore ci files
  feat: switch tendermint references to cometbft
Fraccaman added a commit that referenced this pull request Jun 16, 2023
@Fraccaman
Merge branch 'origin/bengt/cometbft-correct' (#1476)
661649d 
* origin/bengt/cometbft-correct:
  ci: restore ci files
  feat: switch tendermint references to cometbft
@Fraccaman Fraccaman merged commit 806f54f into main Jun 17, 2023
@Fraccaman Fraccaman deleted the bengt/cometbft-correct branch June 17, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fraccaman Fraccaman Fraccaman approved these changes

@tzemanovic tzemanovic tzemanovic left review comments

@brentstone brentstone Awaiting requested review from brentstone

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bengtlofgren @adrianbrink @tzemanovic @Fraccaman