PoS: re-usable bonds and unbonds query #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/pos-bonds-query-reuse
branch
from
405cb92
to
8d4af14
Compare
|
I might be missing some way to call the function, but do the new functions need to be added to |
ah sry, my misunderstanding - I'll move it there instead |
|
moved the new function and types in 2c5f461 |
tzemanovic
force-pushed
the
tomas/pos-bonds-query-reuse
branch
from
2c5f461
to
7b74871
Compare
tzemanovic
added a commit
that referenced
this pull request
Jun 12, 2023
* tomas/pos-bonds-query-reuse: changelog: add #1518 app/client/rpc: use enriched bonds and unbonds query shared/rpc: add bonds and unbonds details query enriched with extras
Closed
Fraccaman
added a commit
that referenced
this pull request
Jun 14, 2023
* origin/tomas/pos-bonds-query-reuse: changelog: add #1518 app/client/rpc: use enriched bonds and unbonds query shared/rpc: add bonds and unbonds details query enriched with extras
Fraccaman
pushed a commit
that referenced
this pull request
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on 0.17.0
The bonds and unbonds query calculations performed for the CLI are moved to the shared crate
fn enriched_bonds_and_unbondsto allow re-use.Additionally, the withdrawable amounts didn't respect the current epoch (it was just a sum of unbonds) which is now checked properly.