PoS: delay slash validator set update when next epoch is done in TM #1582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/slash-validator-delay-set-update
branch
from
3a58151
to
080f1af
Compare
tzemanovic
added a commit
that referenced
this pull request
Jun 19, 2023
brentstone
force-pushed
the
tomas/slash-validator-delay-set-update
branch
from
ace3bae
to
ece8e6e
Compare
brentstone
approved these changes
Jun 21, 2023
tzemanovic
added a commit
that referenced
this pull request
Jun 21, 2023
* tomas/slash-validator-delay-set-update: changelog: add #1582 PoS: delay slash validator set update when next epoch is done in TM
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on v0.17.4.
As caught by e.g. https://github.com/anoma/namada/actions/runs/5280174696/jobs/9551903699?pr=1569
When the epoch change conditions are met, we send validator set update to TM, which takes 2 blocks before the change applies. To stay in sync with TM, we delay epoch update by 2 blocks as well. However, when we receive slashable evidence and the validator set update has already been applied but we're not yet on the new epoch, we have to queue up slashed validator removal from validator set by another epoch.