Fix bug in unjail-validator that crashed testnet v0.20.1 #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls update wasm |
tzemanovic
approved these changes
Aug 8, 2023
juped
added a commit
that referenced
this pull request
Aug 9, 2023
…to main * namada/brent/fix-unjail-bug: [ci] wasm checksums update changelog: add #1793 pos/tests: unit test for unjailing pos/lib: fix bug in error-catching
|
unrelated to #1790, @Fraccaman confirmed this in a devnet with this patchset |
Fraccaman
added a commit
that referenced
this pull request
Aug 11, 2023
* origin/brent/fix-unjail-bug: [ci] wasm checksums update changelog: add #1793 pos/tests: unit test for unjailing pos/lib: fix bug in error-catching
Closed
Fraccaman
added a commit
that referenced
this pull request
Aug 13, 2023
* origin/brent/fix-unjail-bug: [ci] wasm checksums update changelog: add #1793 pos/tests: unit test for unjailing pos/lib: fix bug in error-catching
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Resolves a bug in the error handling of
fn unjail_validator.This bug led to a failure in the testnet based on v0.20.1. In the testnet, a validator who had previously been jailed, and was eligible to unjail themselves, seems to have submitted an unjail transaction twice. The second submission mistakenly did not throw an error, leading to a second insertion of the validator back into the consensus set, which then led to a panic from CometBFT for duplicate validators.
closes #1790
Indicate on which release or other PRs this topic is based on
v0.20.1
Checklist before merging to
draft