"testing" feature guard masp proofs load/save #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2023
Fraccaman
approved these changes
Aug 23, 2023
Closed
Fraccaman
added a commit
that referenced
this pull request
Aug 28, 2023
* origin/tomas/feature-guard-masp-proofs-load: changelog: add #1828 shared/types/control_flow: fix warn when no-default-features shared/ledger/masp: "testing" feature guard proofs load/save make check-crates: check that shared can build for wasm target
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tomas/feature-guard-masp-proofs-load: changelog: add #1828 shared/types/control_flow: fix warn when no-default-features shared/ledger/masp: "testing" feature guard proofs load/save make check-crates: check that shared can build for wasm target
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/tomas/feature-guard-masp-proofs-load: changelog: add #1828 shared/types/control_flow: fix warn when no-default-features shared/ledger/masp: "testing" feature guard proofs load/save make check-crates: check that shared can build for wasm target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
To avoid issues with using shared crate for web wasm build, the newly added #1768 is put behind "testing" feature. Additionally,
make check-cratesthat runs in the CI is extended to ensure that the wasm for web can be built from shared crate.Indicate on which release or other PRs this topic is based on
Checklist before merging to
draft