Don't merkelize replay protection keys #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you skip it also when restoring a merkle tree? namada/core/src/ledger/storage/mod.rs Line 731 in 71d8153 |
grarco
force-pushed
the
grarco/unmerkle-replay-protection
branch
from
c7a9c5c
to
afe06c6
Compare
Done it, thanks for pointing it out! 👍🏻 |
grarco
force-pushed
the
grarco/unmerkle-replay-protection
branch
from
afe06c6
to
fdfcfd9
Compare
yito88
approved these changes
Sep 1, 2023
Fraccaman
approved these changes
Sep 1, 2023
|
feel free to merge it to draft! |
Closed
grarco
added a commit
that referenced
this pull request
Sep 4, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/grarco/unmerkle-replay-protection: changelog: add #1863 Adds unit test for replay keys merkle tree Handles remaining tree ops for replay Moves replay protection key check in storage Adjusts `has_key` implementation for replay protection keys Avoid replay protection keys when deleting from merkle tree Renames replay protection storage api Avoids merkelizing replay protection keys
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/grarco/unmerkle-replay-protection: changelog: add #1863 Adds unit test for replay keys merkle tree Handles remaining tree ops for replay Moves replay protection key check in storage Adjusts `has_key` implementation for replay protection keys Avoid replay protection keys when deleting from merkle tree Renames replay protection storage api Avoids merkelizing replay protection keys
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/grarco/unmerkle-replay-protection: changelog: add #1863 Adds unit test for replay keys merkle tree Handles remaining tree ops for replay Moves replay protection key check in storage Adjusts `has_key` implementation for replay protection keys Avoid replay protection keys when deleting from merkle tree Renames replay protection storage api Avoids merkelizing replay protection keys
Fraccaman
added a commit
that referenced
this pull request
Sep 6, 2023
* origin/grarco/unmerkle-replay-protection: changelog: add #1863 Adds unit test for replay keys merkle tree Handles remaining tree ops for replay Moves replay protection key check in storage Adjusts `has_key` implementation for replay protection keys Avoid replay protection keys when deleting from merkle tree Renames replay protection storage api Avoids merkelizing replay protection keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Avoid adding the replay protection storage subkey to the merkle tree.
This does NOT address (not even partially) #1566.
Indicate on which release or other PRs this topic is based on
v0.21.1
Checklist before merging to
draft