-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Epoched
storage objects
#1943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
We affected the tests
that now need to have params initialized for epoched data access |
pls update wasms |
tzemanovic
approved these changes
Sep 29, 2023
tzemanovic
reviewed
Sep 29, 2023
Closed
brentstone
added a commit
that referenced
this pull request
Oct 16, 2023
* brent/refactor-past-epoch-offsets: [ci] wasm checksums update changelog: add #1943 test/PoS/epoched: init PoS params and fix `PastEpochs` type param test/eth: init storage with PoS params where needed cleaning: remove unused code + improve docstrings refactor `Epoched` for past epochs
brentstone
added a commit
that referenced
this pull request
Oct 16, 2023
* brent/refactor-past-epoch-offsets: [ci] wasm checksums update changelog: add #1943 test/PoS/epoched: init PoS params and fix `PastEpochs` type param test/eth: init storage with PoS params where needed cleaning: remove unused code + improve docstrings refactor `Epoched` for past epochs
brentstone
added a commit
that referenced
this pull request
Oct 16, 2023
* brent/refactor-past-epoch-offsets: [ci] wasm checksums update changelog: add #1943 test/PoS/epoched: init PoS params and fix `PastEpochs` type param test/eth: init storage with PoS params where needed cleaning: remove unused code + improve docstrings refactor `Epoched` for past epochs
brentstone
added a commit
that referenced
this pull request
Oct 16, 2023
* brent/refactor-past-epoch-offsets: [ci] wasm checksums update changelog: add #1943 test/PoS/epoched: init PoS params and fix `PastEpochs` type param test/eth: init storage with PoS params where needed cleaning: remove unused code + improve docstrings refactor `Epoched` for past epochs
Fraccaman
added a commit
that referenced
this pull request
Oct 23, 2023
* brent/refactor-past-epoch-offsets: [ci] wasm checksums update changelog: add #1943 test/PoS/epoched: init PoS params and fix `PastEpochs` type param test/eth: init storage with PoS params where needed cleaning: remove unused code + improve docstrings refactor `Epoched` for past epochs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Allow for more dynamic bookkeeping of the number of past epochs kept in an
Epoched
andEpochedDelta
storage object. Previously, this number was determined by a constu64
, but now it can be dependent on proof-of-stake parameters.Indicate on which release or other PRs this topic is based on
v0.23.0
Checklist before merging to
draft