Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Epoched storage objects #1943

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Conversation

brentstone
Copy link
Contributor

@brentstone brentstone commented Sep 26, 2023

Describe your changes

Allow for more dynamic bookkeeping of the number of past epochs kept in an Epoched and EpochedDelta storage object. Previously, this number was determined by a const u64, but now it can be dependent on proof-of-stake parameters.

Indicate on which release or other PRs this topic is based on

v0.23.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@brentstone brentstone mentioned this pull request Sep 26, 2023
2 tasks
@brentstone brentstone marked this pull request as ready for review September 28, 2023 00:23
@tzemanovic
Copy link
Member

We affected the tests

     protocol::transactions::votes::update::tests::test_apply_duplicate_votes
    protocol::transactions::votes::update::tests::test_calculate_already_seen

that now need to have params initialized for epoched data access

@brentstone
Copy link
Contributor Author

pls update wasms

@brentstone brentstone added PoS enhancement New feature or request labels Oct 4, 2023
@brentstone brentstone mentioned this pull request Oct 13, 2023
brentstone added a commit that referenced this pull request Oct 16, 2023
* brent/refactor-past-epoch-offsets:
  [ci] wasm checksums update
  changelog: add #1943
  test/PoS/epoched: init PoS params and fix `PastEpochs` type param
  test/eth: init storage with PoS params where needed
  cleaning: remove unused code + improve docstrings
  refactor `Epoched` for past epochs
brentstone added a commit that referenced this pull request Oct 16, 2023
* brent/refactor-past-epoch-offsets:
  [ci] wasm checksums update
  changelog: add #1943
  test/PoS/epoched: init PoS params and fix `PastEpochs` type param
  test/eth: init storage with PoS params where needed
  cleaning: remove unused code + improve docstrings
  refactor `Epoched` for past epochs
brentstone added a commit that referenced this pull request Oct 16, 2023
* brent/refactor-past-epoch-offsets:
  [ci] wasm checksums update
  changelog: add #1943
  test/PoS/epoched: init PoS params and fix `PastEpochs` type param
  test/eth: init storage with PoS params where needed
  cleaning: remove unused code + improve docstrings
  refactor `Epoched` for past epochs
brentstone added a commit that referenced this pull request Oct 16, 2023
* brent/refactor-past-epoch-offsets:
  [ci] wasm checksums update
  changelog: add #1943
  test/PoS/epoched: init PoS params and fix `PastEpochs` type param
  test/eth: init storage with PoS params where needed
  cleaning: remove unused code + improve docstrings
  refactor `Epoched` for past epochs
Fraccaman added a commit that referenced this pull request Oct 23, 2023
* brent/refactor-past-epoch-offsets:
  [ci] wasm checksums update
  changelog: add #1943
  test/PoS/epoched: init PoS params and fix `PastEpochs` type param
  test/eth: init storage with PoS params where needed
  cleaning: remove unused code + improve docstrings
  refactor `Epoched` for past epochs
@tzemanovic tzemanovic mentioned this pull request Oct 24, 2023
@tzemanovic tzemanovic merged commit 812b2c2 into main Oct 24, 2023
@tzemanovic tzemanovic deleted the brent/refactor-past-epoch-offsets branch October 24, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants