Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: switch from libsecp256k1 to k256 #1958

Merged
merged 2 commits into from
Oct 24, 2023
Merged

deps: switch from libsecp256k1 to k256 #1958

merged 2 commits into from
Oct 24, 2023

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Sep 29, 2023 •
edited by sug0
Loading

Describe your changes

We already have k256 in transitive deps from e.g. tendermint-rs. See also a post describing k256: https://iqlusion.blog/k256-crate-pure-rust-projective-secp256k1-library

Indicate on which release or other PRs this topic is based on

0.23.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@tzemanovic tzemanovic changed the title deps: switch to use libseck256k1 to k256 deps: switch from libseck256k1 to k256 Sep 29, 2023
tzemanovic added a commit that referenced this pull request Sep 29, 2023
@tzemanovic
changelog: add #1958
88a3912
@tzemanovic tzemanovic marked this pull request as ready for review September 29, 2023 13:00
@tzemanovic tzemanovic changed the title deps: switch from libseck256k1 to k256 deps: switch from libsecp256k1 to k256 Sep 29, 2023
@tzemanovic tzemanovic mentioned this pull request Sep 29, 2023
Merged
2 tasks
sug0
sug0 previously approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested compat w/ an ethereum node and signatures are working.

@sug0
Copy link
Contributor

sug0 commented Oct 3, 2023 •
edited
Loading

we should squash the fixup commits first, then rebase #1956 on top

sug0 pushed a commit that referenced this pull request Oct 4, 2023
@tzemanovic @sug0
changelog: add #1958
d0032c9
@sug0 sug0 requested a review from batconjurer October 4, 2023 08:00
batconjurer
batconjurer previously approved these changes Oct 4, 2023
View reviewed changes
@sug0
Copy link
Contributor

sug0 commented Oct 4, 2023

oops, I removed pkcs8 from k256 and now wasms won't compile. will add it back

sug0 added a commit that referenced this pull request Oct 13, 2023
@sug0
Merge branch 'tomas/k256' (#1958)
21c5e58
@sug0 sug0 mentioned this pull request Oct 13, 2023
Closed
@cwgoes cwgoes mentioned this pull request Oct 20, 2023
Closed
29 tasks
Fraccaman added a commit that referenced this pull request Oct 23, 2023
@Fraccaman
Merge branch 'tomas/k256' (#1958)
d0756d6 
* origin/tomas/k256:
  changelog: add #1958
  deps: switch to use libseck256k1 to k256
@tzemanovic tzemanovic mentioned this pull request Oct 24, 2023
Merged
@tzemanovic tzemanovic merged commit 7e4e922 into main Oct 24, 2023
10 of 12 checks passed
@tzemanovic tzemanovic deleted the tomas/k256 branch October 24, 2023 11:26
@tzemanovic tzemanovic mentioned this pull request May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@batconjurer batconjurer batconjurer left review comments

@sug0 sug0 sug0 left review comments

Assignees
No one assigned
Labels
dependencies ethereum-bridge ledger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzemanovic @sug0 @batconjurer