Misc PoS tasks #2178
Merged
Misc PoS tasks #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent/misc-pos-tasks
branch
2 times, most recently
from
1b8d247
to
d5d730f
Compare
brentstone
force-pushed
the
brent/misc-pos-tasks
branch
from
d5d730f
to
ee857d5
Compare
brentstone
added a commit
that referenced
this pull request
Nov 14, 2023
Closed
dingus
brentstone
force-pushed
the
brent/misc-pos-tasks
branch
from
14a5cb8
to
02f5935
Compare
brentstone
added a commit
that referenced
this pull request
Nov 15, 2023
* brent/misc-pos-tasks: changelog: add #2178 fix and test `is_delegator` checked arithmetic remove unnecessary computation of total consensus stake clean up TODOs, docstrings, logging remove unused queries fn fix FutureEpoch offsets of some data panic on slashing error rename to `compute_and_store_total_consensus_stake`
brentstone
added a commit
that referenced
this pull request
Nov 15, 2023
* brent/misc-pos-tasks: changelog: add #2178 fix and test `is_delegator` checked arithmetic remove unnecessary computation of total consensus stake clean up TODOs, docstrings, logging remove unused queries fn fix FutureEpoch offsets of some data panic on slashing error rename to `compute_and_store_total_consensus_stake`
cwgoes
requested changes
Nov 19, 2023
| @@ -327,7 +322,7 @@ where | |||
| current_epoch, | |||
| epoch, | |||
| )?; | |||
| store_total_consensus_stake(storage, epoch)?; | |||
| // compute_and_store_total_consensus_stake(storage, epoch)?; | |||
There was a problem hiding this comment.
It was a redundant operation. We already call this function in init_chain and in finalize_block upon a new epoch, both times before calling copy_validator_sets. It is only necessary to call the function at the beginning of a new epoch and compute the total consensus stake for that current epoch only.
| @@ -308,7 +302,8 @@ where | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// new init genesis | |||
| /// Copies the validator sets into all epochs up through the pipeline epoch at | |||
| /// genesis. Also computes the total | |||
There was a problem hiding this comment.
Thx, will fix up.
| @@ -716,6 +721,8 @@ pub fn is_validator<S>( | |||
| where | |||
| S: StorageRead, | |||
| { | |||
| // TODO: should this check be made different? I suppose it does work but | |||
There was a problem hiding this comment.
Technically this works because all validators need to have a max_commission_rate_change set in storage, but it just seems odd from a readability perspective. May change this in a small PR before the next release
| .total_stake | ||
| .checked_mul(2.into()) | ||
| .expect("Amount overflow while computing minimum required votes") | ||
| + (3u64 - 1u64)) |
There was a problem hiding this comment.
Couldn't it technically overflow here?
There was a problem hiding this comment.
Yeah, you are right, this should have an extra checked_add
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/brent/misc-pos-tasks: changelog: add #2178 fix and test `is_delegator` checked arithmetic remove unnecessary computation of total consensus stake clean up TODOs, docstrings, logging remove unused queries fn fix FutureEpoch offsets of some data panic on slashing error rename to `compute_and_store_total_consensus_stake`
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/brent/misc-pos-tasks: changelog: add #2178 fix and test `is_delegator` checked arithmetic remove unnecessary computation of total consensus stake clean up TODOs, docstrings, logging remove unused queries fn fix FutureEpoch offsets of some data panic on slashing error rename to `compute_and_store_total_consensus_stake`
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/brent/misc-pos-tasks: changelog: add #2178 fix and test `is_delegator` checked arithmetic remove unnecessary computation of total consensus stake clean up TODOs, docstrings, logging remove unused queries fn fix FutureEpoch offsets of some data panic on slashing error rename to `compute_and_store_total_consensus_stake`
Fraccaman
pushed a commit
that referenced
this pull request
Nov 20, 2023
* origin/brent/misc-pos-tasks: changelog: add #2178 fix and test `is_delegator` checked arithmetic remove unnecessary computation of total consensus stake clean up TODOs, docstrings, logging remove unused queries fn fix FutureEpoch offsets of some data panic on slashing error rename to `compute_and_store_total_consensus_stake`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #17, closes #1270. Some other things addressed in this PR:
store_total_consensus_staketocompute_and_store_total_consensus_stakeis_delegatorissueIndicate on which release or other PRs this topic is based on
v0.26.0
Checklist before merging to
draft