CI run wasm step in container #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fraccaman
force-pushed
the
fraccaman/ci-fix-wasm
branch
2 times, most recently
from
9d327b5
to
8f6ed67
Compare
|
still failing wasm checksums |
it looks like it just wasn't up-to-date on main |
|
did you run make build-wasm-scripts-docker |
|
sry, bad commit - accidentally added vp_masp |
tzemanovic
force-pushed
the
fraccaman/ci-fix-wasm
branch
from
66deee3
to
ed84bda
Compare
|
ok, so the main thing here is in fact changes to the dockerfile? |
Merged
juped
reviewed
Aug 1, 2022
docker/namada-wasm/Dockerfile
Outdated
| @@ -1,18 +1,16 @@ | |||
| # This docker is used for deterministic wasm builds | |||
|
|
|||
| # The version should be matching the version set in wasm/rust-toolchain.toml | |||
| FROM rust:1.61.0 | |||
| FROM rust:1.61 | |||
There was a problem hiding this comment.
should stay 1.61.0; right now 1.61 is an alias for it but it might have a patch release
There was a problem hiding this comment.
yeah, lets keep rust:1.61.0. I'll make a commit
Merged
tzemanovic
added a commit
that referenced
this pull request
Aug 1, 2022
* fraccaman/ci-fix-wasm: [ci] docker use rust:1.61.0 update wasm checksums [ci] run specific step in docker container
Merged
Fraccaman
force-pushed
the
fraccaman/ci-fix-wasm
branch
from
fccf65a
to
17fe278
Compare
tzemanovic
added a commit
that referenced
this pull request
Aug 1, 2022
* fraccaman/ci-fix-wasm: [ci] docker use rust:1.61.0 update wasm checksums [ci] run specific step in docker container
Merged
juped
force-pushed
the
fraccaman/ci-fix-wasm
branch
from
17fe278
to
c387c3a
Compare
phy-chain
pushed a commit
to phy-chain/namada
that referenced
this pull request
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.