Make ABCI compile again #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-chf
requested review from
batconjurer and
sug0
and removed request for
batconjurer
|
We are going to await #250 to merge in instead |
phy-chain
pushed a commit
to phy-chain/namada
that referenced
this pull request
Mar 1, 2024
* feat: cleanup memory on rust panic * fix: anoma tests failing * feat: pass error message to the promiseWithTimeout
phy-chain
pushed a commit
to phy-chain/namada
that referenced
this pull request
Mar 1, 2024
This fixes a bug introduced in anoma#317 where `new Query` cannot be called because Query was transpiled to ES5 and relies on the class it extends to also be transpiled, but the parent class was generated from Rust and not transpiled. PR anoma#317 already fixed this for the extension; this commit just sets the target JS version for namada-interface too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted from #281
Although we are not using the default feature flag set in developing
eth-bridge-integration, these are used in CI inmainat the moment which we'll eventually merge in. This PR is the minimal changes to make it so that running "default" commands likemake check,make test-unit, etc. will still compile and pass.