Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove max number of signatures per tx #3380

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

brentstone
Copy link
Collaborator

@brentstone brentstone commented Jun 6, 2024

Describe your changes

Closes #3373.

Indicate on which release or other PRs this topic is based on

v0.39.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

brentstone added a commit that referenced this pull request Jun 6, 2024
@brentstone brentstone marked this pull request as ready for review June 6, 2024 08:30
brentstone added a commit that referenced this pull request Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 96.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 53.88%. Comparing base (879a326) to head (dc23750).

Files Patch % Lines
crates/namada/src/vm/wasm/host_env.rs 96.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3380      +/-   ##
==========================================
- Coverage   53.92%   53.88%   -0.05%     
==========================================
  Files         317      317              
  Lines      107575   107554      -21     
==========================================
- Hits        58011    57954      -57     
- Misses      49564    49600      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone mentioned this pull request Jun 6, 2024
brentstone added a commit that referenced this pull request Jun 7, 2024
* brent/remove-max-sigs:
  changelog: add #3380
  remove check for maximum number of signatures per tx
@brentstone brentstone merged commit 88f3003 into main Jul 5, 2024
16 of 19 checks passed
@brentstone brentstone deleted the brent/remove-max-sigs branch July 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove max_signature from the genesis file
3 participants