ListSnapshots and LoadSnapshotChunk methods #3386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3386 +/- ##
==========================================
+ Coverage 53.92% 53.96% +0.03%
==========================================
Files 317 318 +1
Lines 107575 107912 +337
==========================================
+ Hits 58011 58230 +219
- Misses 49564 49682 +118 ☔ View full report in Codecov by Sentry. |
tzemanovic
reviewed
Jun 7, 2024
tzemanovic
reviewed
Jun 7, 2024
tzemanovic
previously approved these changes
Jun 7, 2024
Closed
2 tasks
tzemanovic
previously approved these changes
Jun 10, 2024
sug0
previously approved these changes
Jun 11, 2024
| let chunk_start = if chunk == 0 { | ||
| 0usize | ||
| } else { | ||
| let prev = checked!(usize::try_from(chunk).unwrap() - 1).unwrap(); |
There was a problem hiding this comment.
we should be careful with these checked arithmetic unwraps. in theory cometbft won't provide bogus values, but they could crash the ledger
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
Co-authored-by: Tiago Carvalho <sugoiuguu@tfwno.gf>
batconjurer
force-pushed
the
bat/feat/list-and-offer-snapshots
branch
from
b35b659
to
dbf48a2
Compare
batconjurer
force-pushed
the
bat/feat/list-and-offer-snapshots
branch
from
dbf48a2
to
f79afd1
Compare
brentstone
added a commit
that referenced
this pull request
Jun 28, 2024
* bat/feat/list-and-offer-snapshots: rebasing tinies Added changelog
brentstone
added a commit
that referenced
this pull request
Jul 4, 2024
* origin/bat/feat/list-and-offer-snapshots: rebasing tinies Added changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Addresses the third point and part of the fourth point of Issue #3307
ListSnapshotsABCI callLoadSnapshotChunkABCI callIndicate on which release or other PRs this topic is based on
Built on top of #3383
Checklist before merging to
draft