Replace f64 with rust_decimal in token conversions
#436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
brent/remove-f64
branch
4 times, most recently
from
f583f67
to
5050c24
Compare
|
pls update wasm |
tzemanovic
previously approved these changes
Oct 26, 2022
tzemanovic
previously approved these changes
Oct 26, 2022
tzemanovic
added a commit
that referenced
this pull request
Oct 26, 2022
* brent/remove-f64: [ci] wasm checksums update replace floating point arithm from token module with rust_decimal
brentstone
added a commit
that referenced
this pull request
Oct 26, 2022
* brent/remove-f64: changelog: #436 [ci] wasm checksums update replace floating point arithm from token module with rust_decimal
brentstone
force-pushed
the
brent/remove-f64
branch
from
cc7ebde
to
072c44f
Compare
|
pls update wasms |
tzemanovic
approved these changes
Nov 2, 2022
tzemanovic
added a commit
that referenced
this pull request
Nov 2, 2022
…ration * origin/brent/remove-f64: changelog: #436 [ci] wasm checksums update replace floating point arithm from token module with rust_decimal
tzemanovic
added a commit
that referenced
this pull request
Nov 10, 2022
* brent/validator-commission-rates: changelog: add #695 [ci] wasm checksums update addressing 2nd round of review comments async tx to change validator commission rate add vp validator to wasms fix: critical flaw in pos VP that was prematurely returning true add max commission rate info to validation and pos state machine test validator VP that checks source and signature for a commission rate change tx changes in response to review comments [ci] wasm checksums update fix pos state machine test add max change info to query of validator commission rate fix get of epoched commission rate before pipeline bug fix: consensus key validation error commission change wasm tx test: fix and update validation fix error convention wasm tx test for changing validator commission rate [ci] wasm checksums update improve docs fix commission rate validation on validator initialization init validator: add commission rate required args for tests cleaning: incl fmt + clippy bug fix from splitting this PR off of #388 include and update `rust_decimal` add missing commission rate-related instances commission rate: query + refactor validator change tx epoched commission rate and tx for validator to change their rate require commission rate input data for new validators introduce validator commission rate and changes changelog: #687 remove staking rewards address from cli strings and docs strings wallet: remove validator rewards key client: remove staking rewards address from init-validator result remove staking reward address from genesis toml files remove staking reward address from all code changelog: #436 [ci] wasm checksums update replace floating point arithm from token module with rust_decimal
tzemanovic
added a commit
that referenced
this pull request
Nov 10, 2022
* brent/validator-commission-rates: changelog: add #695 [ci] wasm checksums update addressing 2nd round of review comments async tx to change validator commission rate add vp validator to wasms fix: critical flaw in pos VP that was prematurely returning true add max commission rate info to validation and pos state machine test validator VP that checks source and signature for a commission rate change tx changes in response to review comments [ci] wasm checksums update fix pos state machine test add max change info to query of validator commission rate fix get of epoched commission rate before pipeline bug fix: consensus key validation error commission change wasm tx test: fix and update validation fix error convention wasm tx test for changing validator commission rate [ci] wasm checksums update improve docs fix commission rate validation on validator initialization init validator: add commission rate required args for tests cleaning: incl fmt + clippy bug fix from splitting this PR off of #388 include and update `rust_decimal` add missing commission rate-related instances commission rate: query + refactor validator change tx epoched commission rate and tx for validator to change their rate require commission rate input data for new validators introduce validator commission rate and changes changelog: #687 remove staking rewards address from cli strings and docs strings wallet: remove validator rewards key client: remove staking rewards address from init-validator result remove staking reward address from genesis toml files remove staking reward address from all code changelog: #436 [ci] wasm checksums update replace floating point arithm from token module with rust_decimal
juped
added a commit
that referenced
this pull request
Nov 14, 2022
* namada/pos-integration: (120 commits) [ci] wasm checksums update changelog: add #707 remove comments to self convert to tm voting power in `update_epoch` client: replace voting power with bonded stake in queries, etc fix pos state machine test clean up naming of "validator total deltas" -> "validator deltas" fix client voting power query fix `TendermintValidator::power` clippy: suppress unused validation vars (may need later) fmt + cleanup after cherrypicking commits from #388 more voting_power removal and accurate variable renaming keep voting_power as a possible client query change `validator_total_deltas` -> `validator_deltas` Update wasm tx_(un)bond with VotingPower removal refactor VotingPower out of PoS VP continue refactoring away VotingPower refactor out VotingPower(Delta) in pos crate, distinguish total and validator deltas [ci] wasm checksums update changelog: add #708 remove `min_duration` from `ParametersConfig` remove `staked_ratio` and `pos_inflation_amount` from `ParametersConfig` update comments [ci] wasm checksums update fmt and includes updates to accommodate `tm_votes_per_token` relative to namnam Update rewards parameters and distribution update toml files with latest parameters and values fix arb_amount to max out at max tm voting power (fix wasm test bug) storage change: last inflation rate -> last inflation token amount fix: write all fields in Parameters storage in `init_storage` fix initial staked ratio parameter at genesis update rust_decimal version + fmt clean comments and toml files of basis points fix correct inner type of ValidationError::TotalVotingPowerTooLarge more decimal_mult function uses add fns to multiply Decimal and integer type, return truncated integer remove BasisPoints and change relevant parameters to Decimal type documentation updates + unused imports removal rename reward_rate -> inflation_rate for pos specify read or write intentions for parameters storage keys add target_staked_ratio to PoS params update max inflation rate in params (formerly max_staking_rewards_rate) rename `votes_per_token` to `tm_votes_per_token` since this will only be used to interface with tendermint add new parameters needed for rewards PD controller to the Parameters storage add max_staking_reward_rate to PosParams clarify+rename 'epoch_storage_key' as 'epoch_duration_storage_key' changelog: add #695 [ci] wasm checksums update addressing 2nd round of review comments async tx to change validator commission rate changelog: add #582 add vp validator to wasms fix: critical flaw in pos VP that was prematurely returning true add max commission rate info to validation and pos state machine test validator VP that checks source and signature for a commission rate change tx changes in response to review comments [ci] wasm checksums update fix pos state machine test add max change info to query of validator commission rate fix get of epoched commission rate before pipeline bug fix: consensus key validation error commission change wasm tx test: fix and update validation fix error convention wasm tx test for changing validator commission rate [ci] wasm checksums update governance: more refactor wasm: update checksums chore: rebuild wasm for test governance: more refactor queries/shell: refactor to single def queries/router: rm dbg prints queries: add more PoS queries and use them for gov RPC: add PoS is_validator and bond_amount queries shared: implement PosReadOnly for Storage governance: more refactor governance: more refactor governance: refactor with storage api fix: rename native token in e2e genesis file [ci] wasm checksums update [ci] wasm checksums update improve docs fix commission rate validation on validator initialization init validator: add commission rate required args for tests cleaning: incl fmt + clippy bug fix from splitting this PR off of #388 include and update `rust_decimal` add missing commission rate-related instances commission rate: query + refactor validator change tx epoched commission rate and tx for validator to change their rate require commission rate input data for new validators introduce validator commission rate and changes changelog: #687 remove staking rewards address from cli strings and docs strings wallet: remove validator rewards key client: remove staking rewards address from init-validator result remove staking reward address from genesis toml files remove staking reward address from all code changelog: #436 [ci] wasm checksums update ...
tzemanovic
added a commit
that referenced
this pull request
Nov 16, 2022
* brent/remove-f64: changelog: #436 [ci] wasm checksums update replace floating point arithm from token module with rust_decimal
Closed
tzemanovic
added a commit
that referenced
this pull request
Nov 16, 2022
* brent/validator-commission-rates: changelog: add #695 [ci] wasm checksums update addressing 2nd round of review comments async tx to change validator commission rate add vp validator to wasms fix: critical flaw in pos VP that was prematurely returning true add max commission rate info to validation and pos state machine test validator VP that checks source and signature for a commission rate change tx changes in response to review comments [ci] wasm checksums update fix pos state machine test add max change info to query of validator commission rate fix get of epoched commission rate before pipeline bug fix: consensus key validation error commission change wasm tx test: fix and update validation fix error convention wasm tx test for changing validator commission rate [ci] wasm checksums update improve docs fix commission rate validation on validator initialization init validator: add commission rate required args for tests cleaning: incl fmt + clippy bug fix from splitting this PR off of #388 include and update `rust_decimal` add missing commission rate-related instances commission rate: query + refactor validator change tx epoched commission rate and tx for validator to change their rate require commission rate input data for new validators introduce validator commission rate and changes changelog: #687 remove staking rewards address from cli strings and docs strings wallet: remove validator rewards key client: remove staking rewards address from init-validator result remove staking reward address from genesis toml files remove staking reward address from all code changelog: #436 [ci] wasm checksums update replace floating point arithm from token module with rust_decimal
juped
added a commit
that referenced
this pull request
Nov 30, 2022
#695) into main minor evil changes * namada/brent/validator-commission-rates: changelog: add #695 [ci] wasm checksums update addressing 2nd round of review comments async tx to change validator commission rate add vp validator to wasms fix: critical flaw in pos VP that was prematurely returning true add max commission rate info to validation and pos state machine test validator VP that checks source and signature for a commission rate change tx changes in response to review comments [ci] wasm checksums update fix pos state machine test add max change info to query of validator commission rate fix get of epoched commission rate before pipeline bug fix: consensus key validation error commission change wasm tx test: fix and update validation fix error convention wasm tx test for changing validator commission rate [ci] wasm checksums update improve docs fix commission rate validation on validator initialization init validator: add commission rate required args for tests cleaning: incl fmt + clippy bug fix from splitting this PR off of #388 include and update `rust_decimal` add missing commission rate-related instances commission rate: query + refactor validator change tx epoched commission rate and tx for validator to change their rate require commission rate input data for new validators introduce validator commission rate and changes changelog: #687 remove staking rewards address from cli strings and docs strings wallet: remove validator rewards key client: remove staking rewards address from init-validator result remove staking reward address from genesis toml files remove staking reward address from all code changelog: #436 [ci] wasm checksums update replace floating point arithm from token module with rust_decimal
phy-chain
pushed a commit
to phy-chain/namada
that referenced
this pull request
Mar 1, 2024
* feat(extension): decoupling vault from keyring in order to have a master password for the extension * feat(extension, app): adding a few tests for vault * feat(extension): adding lock extension message to ExtensionBroadcaster * feat(extension,setup): optional password field, if master password is already set-up * feat(extension): fixing some bugs on app locking and some refactory * feat(extension): adding lock functionality + big refactory on App * feat(components): tweaking spacements and sizing * feat(components): adding basic button hover * feat(extension,tests): improving vault tests * feat(extension, app): change password screen with a temporary location * feat(extension, app): unifying ledger accounts in the keyring + necessary changes * feat(tests): updating unit tests to reflect Vault changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #435.
Based on v0.9.0