Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to tendermint fork release v0.1.4-abciplus #667

Merged
merged 6 commits into from
Dec 16, 2022

Conversation

tzemanovic
Copy link
Member

@tzemanovic tzemanovic commented Oct 21, 2022

the versioning is not semver compliant - it's just for temp fork releases

@tzemanovic tzemanovic requested a review from juped October 21, 2022 14:56
Copy link
Member

@juped juped left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have actually been using a slightly different version, currently marked by a ledger-main branch (it's the same but happens to have one more rpc endpoint)

in the interests of standardizing everything, this branch should update the CI to whatever version it specifies as well (it may only differ in the version number constant, but we should stick to it)

@tzemanovic tzemanovic changed the title switch to tendermint fork release v0.1.2-abciplus switch to tendermint fork release v0.1.3-abciplus Oct 24, 2022
@Fraccaman
Copy link
Member

this should also update the docker image in docker/namada/Dockerfile line 28

@tzemanovic
Copy link
Member Author

this should also update the docker image in docker/namada/Dockerfile line 28

done, thanks!

@tzemanovic
Copy link
Member Author

in the interests of standardizing everything, this branch should update the CI to whatever version it specifies as well (it may only differ in the version number constant, but we should stick to it)

@juped I missed this before, it's a good call, updated

@tzemanovic tzemanovic added this to the v0.11.0 milestone Nov 16, 2022
@tzemanovic
Copy link
Member Author

this is held up for now on another tendermint update with prometheus fix

@tzemanovic tzemanovic changed the title switch to tendermint fork release v0.1.3-abciplus switch to tendermint fork release v0.1.4-abciplus Nov 21, 2022
@tzemanovic
Copy link
Member Author

this is held up for now on another tendermint update with prometheus fix

tested with v0.1.4-abciplus and ready

@tzemanovic
Copy link
Member Author

we may be able to switch back to official releases instead - see #838

@james-chf
Copy link
Contributor

Yes it looks like the only difference now between our fork and upstream v0.37.0-rc1 is the events endpoint, which we aren't using. tendermint/tendermint@v0.37.0-rc1...heliaxdev:tendermint:ledger-main

So we could switch to using upstream v0.37.0-rc1

@tzemanovic tzemanovic merged commit 5f7dd04 into main Dec 16, 2022
@tzemanovic tzemanovic deleted the tomas/get-tendermint-0.1.2-abciplus branch December 16, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants