Ethereum bridge VP and e2e test clean up #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-chf
force-pushed
the
james/mainline/ethbridge-e2e-cleanup
branch
from
3708b3f
to
eb5e239
Compare
|
pls update wasm |
james-chf
force-pushed
the
james/mainline/ethbridge-e2e-cleanup
branch
from
92ffdcb
to
ac80c12
Compare
james-chf
force-pushed
the
james/mainline/ethbridge-e2e-cleanup
branch
from
57a18e1
to
f165cf3
Compare
james-chf
force-pushed
the
james/mainline/ethbridge-e2e-cleanup
branch
from
f165cf3
to
8efb474
Compare
sug0
reviewed
Feb 8, 2023
| /// # Examples | ||
| /// | ||
| /// ``` | ||
| /// let storage_key = storage_key("queue"); | ||
| /// assert_eq!(storage_key, "#atest1v9hx7w36g42ysgzzwf5kgem9ypqkgerjv4ehxgpqyqszqgpqyqszqgpqyqszqgpqyqszqgpq8f99ew/queue"); | ||
| /// ``` | ||
| fn storage_key(path: &str) -> String { | ||
| format!("#{ETH_BRIDGE_ADDRESS}/{}", path) | ||
| format!("#{}/{}", eth_bridge::vp::ADDRESS, path) |
There was a problem hiding this comment.
is this the same as namada_core::ledger::eth_bridge::ADDRESS?
There was a problem hiding this comment.
I think so but namada_core::ledger::eth_bridge::ADDRESS isn't present in this PR. This PR is a rework of a small cleanup PR (#323) which never got merged
batconjurer
approved these changes
Feb 8, 2023
sug0
approved these changes
Feb 8, 2023
|
the tx data passed to the |
tzemanovic
added a commit
that referenced
this pull request
Mar 31, 2023
* james/mainline/ethbridge-e2e-cleanup: Add changelog Add comment for the test Simplify test and remove references to queue key Remove references to anoman/anomac Remove no longer used eth_bridge::storage module Rename test to unauthorized_tx_cannot_write_storage Don't use duplicate ETH_BRIDGE_ADDRESS
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #668
This PR cleans up some stale code relating to the Ethereum bridge in
main, and tidies up an e2e test. Adapted from #323.