Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce serialized size of BlockResults #859

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Reduce serialized size of BlockResults #859

merged 1 commit into from
Dec 13, 2022

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Dec 2, 2022

We replace bit-vec with the index set implementations in https://github.com/heliaxdev/index-set, with the goal of reducing the serialized size (in bytes) of BlockResults instances. The representation of index_set::vec::VecIndexSet is more compact than the bit vector implementation we previously depended on.

@sug0 sug0 added enhancement New feature or request ledger labels Dec 2, 2022
tzemanovic
tzemanovic approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

tzemanovic added a commit that referenced this pull request Dec 5, 2022
@tzemanovic
Merge branch 'tiago/main/index-set-block-results' (#859)
96238d4 
* tiago/main/index-set-block-results:
  Reduce serialized size of BlockResults
@tzemanovic tzemanovic mentioned this pull request Dec 5, 2022
Closed
murisi
murisi approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@murisi murisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks correct to me. Assuming that transaction rejections are sparse enough, this should be a major improvement. (Conversely if rejections occur frequently in production, then we would have to be paying for the additional BTreeMap indicies.)

tzemanovic added a commit that referenced this pull request Dec 6, 2022
@tzemanovic
Merge branch 'tiago/main/index-set-block-results' (#859)
e655aaf 
* tiago/main/index-set-block-results:
  Reduce serialized size of BlockResults
@juped juped merged commit 1c1579a into main Dec 13, 2022
juped added a commit that referenced this pull request Dec 13, 2022
@juped
changelog: add #859
685125b
juped added a commit that referenced this pull request Dec 13, 2022
@juped
Merge branch 'tiago/main/index-set-block-results' (#859) into main
0d4c521 
* tiago/main/index-set-block-results:
  changelog: add #859
  Reduce serialized size of BlockResults
@juped juped deleted the tiago/main/index-set-block-results branch December 13, 2022 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murisi murisi murisi approved these changes

@tzemanovic tzemanovic tzemanovic approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ledger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sug0 @tzemanovic @murisi @juped