-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove reverse prefix iter #912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pls update wasm |
we can also remove |
done |
brentstone
reviewed
Dec 26, 2022
brentstone
approved these changes
Dec 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from the mismatched_prefix
usage in test_persistent_storage_prefix_iter
, LGTM
brentstone
added a commit
that referenced
this pull request
Dec 27, 2022
…epoched-MOVE-WRITELOG * tomas+brent/fix-iter-prefix: storage: extend iter_prefix test storage: rename `fn commit` to `commit_block` write_log: allow to commit genesis txs write_log: add prefix iter shared: Add WlStorage, combining WriteLog with Storage core/storage: add a warning to `iter_prefix` core/storage/mockDB: remove unused `reverse_order` flag [ci] wasm checksums update changelog: add #912 wasm_for_tests: make storage: remove rev_iter_prefix, which doesn't work as expected test in apps/ledger/storage: test prefix iterators
tzemanovic
added a commit
that referenced
this pull request
Dec 28, 2022
* origin/tomas/gats-lifetimes-refactor: [ci] wasm checksums update core/storage: remove redundant `StorageWrite` impl for mut ref changelog: #966 core/storage_api: use GATs to hide lifetime in StorageRead trait core/storage/mockDB: remove unused `reverse_order` flag [ci] wasm checksums update changelog: add #912 wasm_for_tests: make storage: remove rev_iter_prefix, which doesn't work as expected test in apps/ledger/storage: test prefix iterators
Merged
bengtlofgren
pushed a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #902