Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove reverse prefix iter #912

Merged
merged 6 commits into from
Jan 10, 2023
Merged

remove reverse prefix iter #912

merged 6 commits into from
Jan 10, 2023

Conversation

tzemanovic
Copy link
Member

closes #902

@tzemanovic tzemanovic changed the title remove prefix iter remove reverse prefix iter Dec 16, 2022
@tzemanovic
Copy link
Member Author

pls update wasm

@tzemanovic tzemanovic marked this pull request as ready for review December 17, 2022 10:59
@tzemanovic
Copy link
Member Author

we can also remove reverse_order from mockdb.rs

@tzemanovic
Copy link
Member Author

reverse_order

done

Copy link
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the mismatched_prefix usage in test_persistent_storage_prefix_iter, LGTM

brentstone added a commit that referenced this pull request Dec 27, 2022
…epoched-MOVE-WRITELOG

* tomas+brent/fix-iter-prefix:
  storage: extend iter_prefix test
  storage: rename `fn commit` to `commit_block`
  write_log: allow to commit genesis txs
  write_log: add prefix iter
  shared: Add WlStorage, combining WriteLog with Storage
  core/storage: add a warning to `iter_prefix`
  core/storage/mockDB: remove unused `reverse_order` flag
  [ci] wasm checksums update
  changelog: add #912
  wasm_for_tests: make
  storage: remove rev_iter_prefix, which doesn't work as expected
  test in apps/ledger/storage: test prefix iterators
tzemanovic added a commit that referenced this pull request Dec 28, 2022
* origin/tomas/gats-lifetimes-refactor:
  [ci] wasm checksums update
  core/storage: remove redundant `StorageWrite` impl for mut ref
  changelog: #966
  core/storage_api: use GATs to hide lifetime in StorageRead trait
  core/storage/mockDB: remove unused `reverse_order` flag
  [ci] wasm checksums update
  changelog: add #912
  wasm_for_tests: make
  storage: remove rev_iter_prefix, which doesn't work as expected
  test in apps/ledger/storage: test prefix iterators
@tzemanovic tzemanovic mentioned this pull request Dec 28, 2022
@juped juped merged commit 7a70bb2 into main Jan 10, 2023
@juped juped deleted the tomas/remove-prefix-iter branch January 10, 2023 07:08
bengtlofgren pushed a commit that referenced this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove reverse prefix iterator
3 participants