Fix validator commission change wasm test #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
previously approved these changes
Dec 27, 2022
tzemanovic
changed the base branch from
tiago+tomas/main/storage-keys-procmacro
to
main
tzemanovic
approved these changes
Dec 27, 2022
juped
added a commit
that referenced
this pull request
Jan 10, 2023
…tomas/main/storage-keys-procmacro This branch surfaced a bug in a wasm test. Merge the fix to pass tests on this branch. * brent/fix-validator-commission-change-test: wasm: update checksums.json changelog: add #965 remove `ChangeIsZero` error remove dbg statements fix arb rate: prevent same rate and ensure proper bounds
juped
added a commit
that referenced
this pull request
Jan 10, 2023
juped
added a commit
that referenced
this pull request
Jan 11, 2023
Namada 0.13.0 * tag 'v0.13.0': (166 commits) Namada 0.13.0 finalize_block: remove unused import misc: change log level misc: change log level chore: missing file ledger: add some blocks statistics logs changelog: add #972 chore: clippy/fmt ledger: remove/changed some logs ledger: use genesis fees genesis: added parameter to control wrapper tx fees amount wasm: update checksums.json changelog: add #969 test/e2e: add a case to withdraw from PoW faucet client/tx and signing: add wrapper signer balance check and add PoW ledger/queries/vp: add testnet pow and faucet methods wasm/vp_testnet_faucet: check PoW, use withdrawal_limit set in storage expose the `has_valid_pow` result via VP wasm host env validate PoW in mempool, proposal and finalize and keep the result shell/init_chain: init faucet storage, if used add `faucet_account` parameter and set it from `init_chain` if found genesis: add faucet_pow_difficulty and faucet_withdrawal_limit add "mainnet" feature flag, off by default for now storage_api/lazy_map: export `get_data_key` fn for client core/ledger: add testnet_pow module re-export `namada` from `namada_tests` for `namada_core` dev-deps changelog: add #903 changelog: add #975 wasm: update checksums.json Fix consensus params config for ABCI++ wasm: update checksums.json Remove boilerplate code in favor of StorageKeys macro Update Cargo deps Define Keys struct with all ledger param key types Fix #882 changelog: add #926 changelog: add #974 changelog: add #973 wasm: update checksums.json Update documentation/docs/src/user-guide/ibc.md added ibc docs and new favicon Update README.md Update README.md changelog: add #965 remove `ChangeIsZero` error remove dbg statements fix arb rate: prevent same rate and ensure proper bounds Revert "Merge pull request #965 from anoma/brent/fix-validator-commission-change-test" ci: fix e2e test script Reduces block size to 5 MiB Add `max_proposal_bytes` ledger param Moves ledger sleep Refactors ledger sleep Adds start time argument to namada ledger Update README.md Adds const and default token to basic fee changelog: add #968 add `NAMADA_LOG_FMT` env var with one of: full (default), json or pretty [ci] wasm checksums update core/storage: remove redundant `StorageWrite` impl for mut ref changelog: #966 core/storage_api: use GATs to hide lifetime in StorageRead trait changelog: add #962 changelog: add #965 remove `ChangeIsZero` error remove dbg statements fix arb rate: prevent same rate and ensure proper bounds Fixes unit tests Fixes process proposal fee token Fixes fee value in tx contruction Adds fee burning and checks core/storage/mockDB: remove unused `reverse_order` flag Add JSON as an option for logging by env var changed to 0.12.2 ci: install cargo-about after sccache server up Namada 0.12.2 release: cherry-pick release improvements changelog: add #952 prepare_proposal: update comment to reflect hotfix prepare_proposal: use TxRecord struct on ABCI++ build missed a chain-id addition Prioritize wrapper txs during proposal construction Hot fix PrepareProposal added chain id and fixed install docs update pseudocode General housekeeping Reward distribution: general improvements Cubic slashing: general writing improvements Cubic slashing: add new improved pseudocode blurb (Rust-style) Cubic slashing: clarify slash iteration procedure and equation Cubic slashing: fix and improve plot quick fix to cubic slash wasm: update checksums.json changelog: add #911 changelog: add #876 test/core: run less cases on `update_epoch_after_its_duration` test Update link to install section changelog: add #945 ci: install cargo-about on release step make-package.sh: include license information in tarball ...
juped
added a commit
that referenced
this pull request
Jan 12, 2023
Namada 0.13.0 * tag 'v0.13.0': (166 commits) Namada 0.13.0 finalize_block: remove unused import misc: change log level misc: change log level chore: missing file ledger: add some blocks statistics logs changelog: add #972 chore: clippy/fmt ledger: remove/changed some logs ledger: use genesis fees genesis: added parameter to control wrapper tx fees amount wasm: update checksums.json changelog: add #969 test/e2e: add a case to withdraw from PoW faucet client/tx and signing: add wrapper signer balance check and add PoW ledger/queries/vp: add testnet pow and faucet methods wasm/vp_testnet_faucet: check PoW, use withdrawal_limit set in storage expose the `has_valid_pow` result via VP wasm host env validate PoW in mempool, proposal and finalize and keep the result shell/init_chain: init faucet storage, if used add `faucet_account` parameter and set it from `init_chain` if found genesis: add faucet_pow_difficulty and faucet_withdrawal_limit add "mainnet" feature flag, off by default for now storage_api/lazy_map: export `get_data_key` fn for client core/ledger: add testnet_pow module re-export `namada` from `namada_tests` for `namada_core` dev-deps changelog: add #903 changelog: add #975 wasm: update checksums.json Fix consensus params config for ABCI++ wasm: update checksums.json Remove boilerplate code in favor of StorageKeys macro Update Cargo deps Define Keys struct with all ledger param key types Fix #882 changelog: add #926 changelog: add #974 changelog: add #973 wasm: update checksums.json Update documentation/docs/src/user-guide/ibc.md added ibc docs and new favicon Update README.md Update README.md changelog: add #965 remove `ChangeIsZero` error remove dbg statements fix arb rate: prevent same rate and ensure proper bounds Revert "Merge pull request #965 from anoma/brent/fix-validator-commission-change-test" ci: fix e2e test script Reduces block size to 5 MiB Add `max_proposal_bytes` ledger param Moves ledger sleep Refactors ledger sleep Adds start time argument to namada ledger Update README.md Adds const and default token to basic fee changelog: add #968 add `NAMADA_LOG_FMT` env var with one of: full (default), json or pretty [ci] wasm checksums update core/storage: remove redundant `StorageWrite` impl for mut ref changelog: #966 core/storage_api: use GATs to hide lifetime in StorageRead trait changelog: add #962 changelog: add #965 remove `ChangeIsZero` error remove dbg statements fix arb rate: prevent same rate and ensure proper bounds Fixes unit tests Fixes process proposal fee token Fixes fee value in tx contruction Adds fee burning and checks core/storage/mockDB: remove unused `reverse_order` flag Add JSON as an option for logging by env var changed to 0.12.2 ci: install cargo-about after sccache server up Namada 0.12.2 release: cherry-pick release improvements changelog: add #952 prepare_proposal: update comment to reflect hotfix prepare_proposal: use TxRecord struct on ABCI++ build missed a chain-id addition Prioritize wrapper txs during proposal construction Hot fix PrepareProposal added chain id and fixed install docs update pseudocode General housekeeping Reward distribution: general improvements Cubic slashing: general writing improvements Cubic slashing: add new improved pseudocode blurb (Rust-style) Cubic slashing: clarify slash iteration procedure and equation Cubic slashing: fix and improve plot quick fix to cubic slash wasm: update checksums.json changelog: add #911 changelog: add #876 test/core: run less cases on `update_epoch_after_its_duration` test Update link to install section changelog: add #945 ci: install cargo-about on release step make-package.sh: include license information in tarball ...
bengtlofgren
pushed a commit
that referenced
this pull request
May 11, 2023
bengtlofgren
pushed a commit
that referenced
this pull request
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving the wasm test error seen in #926 (comment). This was due to an arbitrary value for a new commission rate that was the same as the previous rate, which threw an error from within
PosActions::change_validator_commission_rate.The arb values for a new rate within
tx_change_validator_commission.rsare now prevented from being the same as the previous rate.Additionally, the previous
ChangeIsZeroerror is removed, and if a tx to change the commission rate to the same as the previous one is submitted, the code instead returns early rather than attempt to make storage changes. Commit 159001e can be removed if we prefer to keep theChangeIsZeroerror.