-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality : Linting and formatting #69
Conversation
I have tested this in a separate branch. Review, if it is okay, then you can run After your review, we can lint it. |
Note that the lint and format are run by the developer. If the person forgets, then the code still gets pushed. No pre-hook like the one described here or some kind of CI automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we include a prettierignore file to ignore node modules when linting?
Yes yes. I didn't add that because prettier ignores that by default... But we can excilicitly ignore that. |
Okay fine. I am trying to finish or fix up #71 ...PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We can set it up later. |
Description
This defined coding standards (code quality) and formatting styles. This was done to help collaborators follow the same style to avoid inconsistency and quality of code.
To do this, ESLint was used as a linting tool for code quality and prettier was used as a formatting tool. The standard extended is the Airbnb JavaScript style guide.
As a result, ESLint and its peer dependencies.
Fixes #60 (issue)
Type of change
Checklist: