-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support rspamd when configured #96
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! See my comments and let me know what you think.
9306fb5
to
9022590
Compare
9022590
to
2417535
Compare
i've reworked this PR to install and configure rspamd internally in the container locally, i can confirm rspamd can be enabled/disabled and the web dashboard requires a password |
@eleith Looks great thanks! In a follow-up I will update our test workflow and add a matrix to test against rspamd and opendkim/dmarc so we can check if services are up as expected. |
Btw do we need to update the |
i was gonna leave it alone in an attempt to keep this PR from growing. but, with that said, this change isn't required (opendkim generated keys still would work) but it would be more aligned with the anonaddy's recommendation to do the following: sudo rspamadm dkim_keygen -s 'default' -b 2048 -d example.com -k /var/lib/rspamd/dkim/example.com.default.key | sudo tee -a /var/lib/rspamd/dkim/example.com.default.pub |
Sure let's do that in a follow-up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks gain!
this PR adds rspamd as an optional service
RSPAMD_ENABLE
can be set to enable the serviceRSPAMD_WEB_PASSWORD
can be be set to require a password when logging into the rspamd web dashboardall configurations were taken from: https://anonaddy.com/self-hosting/
this resolves #93