Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support rspamd when configured #96

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

eleith
Copy link
Contributor

@eleith eleith commented Jan 15, 2022

this PR adds rspamd as an optional service

RSPAMD_ENABLE can be set to enable the service
RSPAMD_WEB_PASSWORD can be be set to require a password when logging into the rspamd web dashboard

all configurations were taken from: https://anonaddy.com/self-hosting/

this resolves #93

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! See my comments and let me know what you think.

examples/nginx-with-rspamd/docker-compose.yml Outdated Show resolved Hide resolved
rootfs/etc/cont-init.d/03-config.sh Outdated Show resolved Hide resolved
examples/nginx-with-rspamd/docker-compose.yml Outdated Show resolved Hide resolved
@eleith
Copy link
Contributor Author

eleith commented Jan 18, 2022

i've reworked this PR to install and configure rspamd internally in the container

locally, i can confirm rspamd can be enabled/disabled and the web dashboard requires a password

@crazy-max
Copy link
Member

@eleith Looks great thanks! In a follow-up I will update our test workflow and add a matrix to test against rspamd and opendkim/dmarc so we can check if services are up as expected.

@crazy-max
Copy link
Member

crazy-max commented Jan 18, 2022

Btw do we need to update the Generate DKIM private/public keypair section in the README relative to Rspamd or is it ok to use opendkim-genkey for it?

README.md Show resolved Hide resolved
@eleith
Copy link
Contributor Author

eleith commented Jan 18, 2022

Btw do we need to update the Generate DKIM private/public keypair section in the README relative to Rspamd or is it ok to use opendkim-genkey for it?

i was gonna leave it alone in an attempt to keep this PR from growing. but, with that said, this change isn't required (opendkim generated keys still would work) but it would be more aligned with the anonaddy's recommendation to do the following:

sudo rspamadm dkim_keygen -s 'default' -b 2048 -d example.com -k /var/lib/rspamd/dkim/example.com.default.key | sudo tee -a /var/lib/rspamd/dkim/example.com.default.pub

@eleith eleith requested a review from crazy-max January 18, 2022 19:23
@crazy-max
Copy link
Member

Btw do we need to update the Generate DKIM private/public keypair section in the README relative to Rspamd or is it ok to use opendkim-genkey for it?

i was gonna leave it alone in an attempt to keep this PR from growing. but, with that said, this change isn't required (opendkim generated keys still would work) but it would be more aligned with the anonaddy's recommendation to do the following:

sudo rspamadm dkim_keygen -s 'default' -b 2048 -d example.com -k /var/lib/rspamd/dkim/example.com.default.key | sudo tee -a /var/lib/rspamd/dkim/example.com.default.pub

Sure let's do that in a follow-up

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks gain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] allow for optional use of rspamd (instead of opendkim / opendmarc)
2 participants