Max min branch #51

Harjacober · 2018-12-19T10:57:10Z

Adds Maximum and Minimum helper functions

o_kere_julo(Minimum)

o_kere_julo returns the minimum number in a list of numbers

o_tobi_julo(Maximum)

o_tobi_julo returns the maximum number in a list of numbers

both functions takes an array or numbers separated by a ',' as argument
if the first argument is an array, the function automatically ignores the other arguments and computes the max or min number in the first argument array.

Usage

var max = o_tobi_julo(34, 22, 56, 24, 4)
max = 56

var min= o_kere_julo(34, 22, 56, 24, 4)
min= 4

var min= o_kere_julo([34, 22, 56, 24, 4])
min= 4

var max= o_kere_julo([34, 22, 56, 24, 4], 45, 545, 45, 445)
max= 56
all other arguments are ignored only the first array argument is recognized

Harjacober · 2018-12-19T12:14:39Z

it should be note that var in the code snippets will be replaced with jeki if to be used in Yorlang

Mastersam07 · 2018-12-19T15:50:45Z

i thought variable declarations are done with jeki not var ?

Mastersam07 · 2018-12-19T15:51:23Z

it should be note that var in the code snippets will be replaced with jeki if to be used in Yorlang

okay.

anoniscoding · 2018-12-19T15:53:50Z

Please add test cases for your code before i leave a review

anoniscoding · 2018-12-19T17:22:25Z

sample/maxmin.yl

@@ -0,0 +1,19 @@
+sope "eleyi a fun wa ni nomba to tobi julo";


Hey bro. Check the test/helpers/ folder to see samples of how test cases were written for other helper functions

Alright I will do that now

Oh! my bad.... Didn't know that was the test you were talking about. I will do that now

@anoniscoding I created test cases already, 3 for each classes, kindly review

anoniscoding · 2018-12-20T14:52:08Z

sample/maxmin.yl

@@ -0,0 +1,19 @@
+sope "eleyi a fun wa ni nomba to tobi julo";
+sope "";


Please delete this file.

anoniscoding · 2018-12-20T14:53:57Z

src/helperise/max_min_helpers/o_kere_julo.js

+ * note that if the first argument is an array, all other arguments are neglected
+ * @returns {[number]} minimumNumber
+ */
+function oKereJulo () {


i'll prefer you rename it to eyiToKereJu

anoniscoding · 2018-12-20T14:54:24Z

src/helperise/max_min_helpers/o_tobi_julo.js

+ * note that if the first argument is an array, all other arguments are neglected
+ * @returns {[number]} maximumNumber
+ */
+function oTobiJulo () {


I'll prefer you rename it eyiToTobiJu

anoniscoding · 2019-01-01T17:54:19Z

src/helperise/max_min_helpers/o_tobi_julo.js

@@ -0,0 +1,26 @@
+/**


Helper ise methods in yorlang have a parameter args that is of type array.
So in this case , we should have function eyiToTobiJu(args). You can reference other helper functions in the codebase to see how this has been applied

The spec for eyiToTobiJu is as follows:

it should be able to take comma separated values that are of type number i.e eyiToTobiJu(1,2,3)

It should be able to take an array as its value i.e eyiToTobiJu([1,2,3]).

Edge cases:

Whenever it takes an array as its value, other parameters after the array shall be ignored i.e eyiToTobiJu([1,2,3], 4, "blah"). 4 and blah in this case will be ignored. eyiToTobiJu will only attempt to find the maximum of the array [1,2,3].

In the event that a non number value is passed in the parameter list e.g eyiToTobiJu(1,2,"blah"), the function should throw an error

Notes:

There's a utility function Array.isArray() in es6

Use const whenever you're not mutating the value of a variable

Please prefer let to var whenever you're mutating the value of variable

args variable is an array of all the parameters passed to an helper function. For example, calling an helper function in yorlang with eyiToTobiJu(1,2,3) will result in the args value being [1,2,3]. Likewise, calling an helper function in yorlang with eyiToTobiJu([1,2,3]) will result in the args value being [[1,2,3]]

Math.max(...args) in the event that all values in args are numbers will return the minimum number

Math.max(...args) in the event that all values in args are not numbers will return NaN

Throw an error when the result of Math.max is NaN

To cater for cases where eyiToTobiJu can take an array as parameter, check if the first value of args is an array using Array.isArray(args[0])

anoniscoding · 2019-01-01T17:57:53Z

src/helperise/max_min_helpers/o_kere_julo.js

@@ -0,0 +1,26 @@
+/**


Helper ise methods in yorlang have a parameter args that is of type array.
So in this case , we should have function eyiToKereJu(args)

The spec for eyiToKereJu is as follows:

it should be able to take comma separated values that are of type number i.e eyiToKereJu(1,2,3)

It should be able to take an array as its value i.e eyiToKereJu([1,2,3])

Edge cases:

Whenever it takes an array as its value, other parameters after the array shall be ignored i.e eyiToKereJu([1,2,3], 4, "blah"). 4 and blah in this case will be ignored. eyiToKereJu will only attempt to find the minimum of the array [1,2,3].

In the event that a non number value is passed in the parameter list e.g eyiToKereJu(1,2,"blah"), the function should throw an error

Notes:

There's a utility function Array.isArray() in es6

Use const whenever you're not mutating the value of a variable

Please prefer let to var whenever you're mutating the value of variable

args variable is an array of all the parameters passed to an helper function. For example, calling an helper function in yorlang with eyiToKereJu(1,2,3) will result in the args value being [1,2,3]. Likewise, calling an helper function in yorlang with eyiToKereJu([1,2,3]) will result in the args value being [[1,2,3]]

Math.min(...args) in the event that all values in args are numbers will return the minimum number

Math.min(...args) in the event that all values in args are not numbers will return NaN

Throw an error when the result of Math.max is NaN

To cater for cases where eyiToKereJu can take an array as parameter, check if the first value of args is an array using Array.isArray(args[0])

Harjacober · 2019-01-02T09:51:09Z

Hey @anoniscoding I followed the guidelines you gave above and updated the helperise eyiToKereJu and eyiToTobiJu and I deleted the file you asked me to. Kindly review again. Thanks

anoniscoding · 2019-01-02T15:15:53Z

src/helperise/max_min_helpers/o_kere_julo.js

+ * note that if the first argument is an array, all other arguments are neglected
+ * @returns {[number]} minimumNumber
+ */
+function eyiToKereJu () {


Following the guidelines, you could have

function eyiToKereJu(args) { if (Array.isArray(args)) { if(Array.isArray(args[0])) args = args[0]; const min = Math.min(...args); if (Number.isNaN(min)) throw new Error("Invalid number params passed to eyiToKereJu"); return min; } throw new Error("Yorlang System Error: args should be an array") }

The above covers all the edge cases where args can be either of the following

[1,2,43]

[[3,2,34]]

[1,"blah",2]

[[32,4,5], "blah", "2"]

Please make sure your test cases covers each of these possible values that could be passed to eyiToKereJu

The above information also applies to eyiToTobiJu

You must also register your helper functions in the file named registeredHelperIse.js

Harjacober · 2019-01-03T21:52:11Z

I optimized the functions, I added more test cases as you requested and I registered the two helper functions at registeredHelperise.js which is now causing conflict. Kindly review again. Thanks

Harjacober added 4 commits December 19, 2018 10:53

created max and min helper functions

f026364

created max and min helper functions

610bd46

created max and min helper functions

aef75c9

created max and min helper functions

912edda

created test cases for max and min

b22bf51

anoniscoding reviewed Dec 19, 2018

View reviewed changes

created test cases for max and min

a7bab57

anoniscoding reviewed Jan 1, 2019

View reviewed changes

optimized helperise function

161e7d9

anoniscoding reviewed Jan 2, 2019

View reviewed changes

optimized and registered max_min_helpers functions

15221f3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Max min branch #51

Max min branch #51

Harjacober commented Dec 19, 2018

Harjacober commented Dec 19, 2018

Mastersam07 commented Dec 19, 2018

Mastersam07 commented Dec 19, 2018

anoniscoding commented Dec 19, 2018

anoniscoding Dec 19, 2018

Harjacober Dec 19, 2018

Harjacober Dec 19, 2018

Harjacober Dec 19, 2018

anoniscoding Dec 20, 2018

anoniscoding Dec 20, 2018 •

edited

Loading

anoniscoding Dec 20, 2018 •

edited

Loading

anoniscoding Jan 1, 2019 •

edited

Loading

anoniscoding Jan 1, 2019

Harjacober commented Jan 2, 2019

anoniscoding Jan 2, 2019

anoniscoding Jan 2, 2019

Harjacober commented Jan 3, 2019

		@@ -0,0 +1,19 @@
		sope "eleyi a fun wa ni nomba to tobi julo";

		@@ -0,0 +1,19 @@
		sope "eleyi a fun wa ni nomba to tobi julo";
		sope "";

Max min branch #51

Are you sure you want to change the base?

Max min branch #51

Conversation

Harjacober commented Dec 19, 2018

o_kere_julo(Minimum)

o_tobi_julo(Maximum)

Usage

Harjacober commented Dec 19, 2018

Mastersam07 commented Dec 19, 2018

Mastersam07 commented Dec 19, 2018

anoniscoding commented Dec 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anoniscoding Dec 20, 2018 • edited Loading

Choose a reason for hiding this comment

anoniscoding Dec 20, 2018 • edited Loading

Choose a reason for hiding this comment

anoniscoding Jan 1, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Harjacober commented Jan 2, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Harjacober commented Jan 3, 2019

anoniscoding Dec 20, 2018 •

edited

Loading

anoniscoding Dec 20, 2018 •

edited

Loading

anoniscoding Jan 1, 2019 •

edited

Loading