Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

Update project to use latest stable and 2018 #11

Merged
merged 6 commits into from
Dec 10, 2018

Conversation

jacobgardner
Copy link
Contributor

Since 1.30 proc-macro has been in stable rust and also includes things such as proper span information on tokens. I don't think there anything left in this crate that needs nightly any more which should allow more developers to use this. We also don't need macro_use either.

With 2018 edition there's a bunch of additional path cleanup we can do in this crate. I probably missed some of the fixes, but it cleans up a lot of the boilerplate at the top of the program.

Let me know if there's any issues.

Copy link
Owner

@anp anp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks so much for the PR :D.

I had a couple of minor nits about glob imports (I know I committed the original sin, but by sending PRs you've demonstrated this code may be valuable and therefore I was wrong to do so!), otherwise this is awesome.

cargo-snapshot/src/main.rs Outdated Show resolved Hide resolved
cargo-snapshot/src/parse_tests.rs Outdated Show resolved Hide resolved
@jacobgardner
Copy link
Contributor Author

I removed all the globs but the prelude one in there. I reverted back to using #[macro_use] for some of the crates because the macros had other macro dependencies which was making the dependency list quite long.

This issue will go away when the crates start using $crate::macro_name, but for now, I thought this made the most sense.

@anp anp merged commit 25423e1 into anp:master Dec 10, 2018
@anp
Copy link
Owner

anp commented Dec 10, 2018

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants