Add add_chapter() as alias for add_page()
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides the option for a more natural-sounding API when generating books.
|
Not totally sure about this one, will need to think a bit about it. Either way, I don't like this class-level attribute assignment aliasing. If I end up merging it, I'll rewrite it as a proper method first. |
|
My reasoning for preferring a class attribute for aliasing is that the method signature only has to be maintained in a single place. Any changes to the arguments of That said, here is a branch using a separate method, if you decide to merge the functionality: https://github.com/elebow/mkepub/commits/add-chapter-alias-for-add-page-method. I can update this PR if you'd like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the option for a more natural-sounding API when generating books.