Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from TravisCI to GitHub Actions #192

Closed
tylerwoonton opened this issue Jan 22, 2020 · 4 comments · Fixed by #203
Closed

Migrate from TravisCI to GitHub Actions #192

tylerwoonton opened this issue Jan 22, 2020 · 4 comments · Fixed by #203
Labels
enhancement New feature or request

Comments

@tylerwoonton
Copy link
Contributor

tylerwoonton commented Jan 22, 2020

What is the feature?

I'd like to suggest moving to GitHub Actions for our CI workflow and moving away from our current TravisCI implementation.

I'd definitely like to get other opinions on this.

What benefits will this change bring?

This will allow us to keep all our workflow for the SDK on GitHub.

We could leverage a lot of the prebuilt workflows, maintaining functionality from our existing pipelines and adding additional functionality too.

Additional context

From what I've read about GitHub Actions and my limited exposure to them, it shouldn't be too hard to migrate our Travis config over.

@tylerwoonton tylerwoonton added the enhancement New feature or request label Jan 22, 2020
@Gman98ish
Copy link
Contributor

image

I have no strong feelings one way or another

@gavtaylor
Copy link
Collaborator

I'd definitely like to get other opinions on this.

no objections from me, I only choose Travis because I've used it before, happy to move to Actions if its a better option.

got some time to pop a PR in for it? :)

@tylerwoonton
Copy link
Contributor Author

got some time to pop a PR in for it? :)

I'll stick a PR in for it tonight, just need to match our config.

@tylerwoonton
Copy link
Contributor Author

@gavtaylor What do we think about GitHub Actions then? We've got it running in the health check now and it's pretty nice imo.

We can do a lot more than this current config does but this replicates what we do on Travis without the need for external services. I'd be keen to see if there were any objections to moving this over.

It was reviewed and approved by @MisterCoder. I've just tweaked the config slightly to match the one used in the health-check package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

3 participants