Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revisit fip attach/detach #33

Merged
merged 1 commit into from
Jun 15, 2022
Merged

revisit fip attach/detach #33

merged 1 commit into from
Jun 15, 2022

Conversation

Overglazed
Copy link
Contributor

  • support FIP assignment on instance resources at creation by specifying a floating_ip_id on the resource
  • support FIP assignment on VPN Endpoint resources at creation by specifying a floating_ip_id on the resource
  • clean up any managed FIPs on the VPN Endpoint resource at deletion time if a floating_ip_id is NOT specified

@Overglazed Overglazed requested a review from 0x4c6565 June 15, 2022 08:18
0x4c6565
0x4c6565 approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@0x4c6565 0x4c6565 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Overglazed Overglazed merged commit 2b7b4e1 into master Jun 15, 2022
@Overglazed Overglazed deleted the fix-fip-resources branch June 15, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4c6565 0x4c6565 0x4c6565 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Overglazed @0x4c6565