Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
tremble authored Sep 11, 2021
1 parent ecf4df2 commit 60df222
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
1 change: 1 addition & 0 deletions plugins/lookup/aws_service_ip_ranges.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
description: 'The AWS region to narrow the ranges to. Examples: us-east-1, eu-west-2, ap-southeast-1'
ipv6_prefixes:
description: 'Return only ipv6 addresses. Option: ipv6_prefixes=True'
version_added: 2.0.0
'''

EXAMPLES = """
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
- name: lookup range with no arguments
set_fact: no_params: "{{ lookup('amazon.aws.aws_service_ip_ranges') }}"
set_fact:
no_params: "{{ lookup('amazon.aws.aws_service_ip_ranges') }}"

- name: assert that we're returned a single string
assert:
Expand Down Expand Up @@ -76,9 +77,9 @@
set_fact:
us_east_1_ips: "{{ lookup('amazon.aws.aws_service_ip_ranges', region='us-east-1', wantlist=True) }}"

- name: lookup IPV6 range with region
set_fact:
us_east_1_ipv6s: "{{ lookup('amazon.aws.aws_service_ip_ranges', region='us-east-1', wantlist=True, ipv6_prefixes=True) }}"
- name: lookup IPV6 range with region
set_fact:
us_east_1_ipv6s: "{{ lookup('amazon.aws.aws_service_ip_ranges', region='us-east-1', wantlist=True, ipv6_prefixes=True) }}"

- name: assert that we're returned a list
assert:
Expand Down

0 comments on commit 60df222

Please sign in to comment.