move get_s3_connection, reduce complexity and increase coverage #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
WIP
This comment was marked as outdated.
This comment was marked as outdated.
tremble
reviewed
Oct 10, 2022
|
recheck (wanted to see if the tests would timeout) |
abikouo
force-pushed
the
test_module_utils_s3
branch
from
0c8f0ba
to
931fbf9
Compare
abikouo
changed the title
tremble
reviewed
Oct 13, 2022
abikouo
force-pushed
the
test_module_utils_s3
branch
from
f507e9e
to
5697191
Compare
goneri
approved these changes
Oct 17, 2022
abikouo
force-pushed
the
test_module_utils_s3
branch
from
9c8f2bd
to
f2fc643
Compare
abikouo
force-pushed
the
test_module_utils_s3
branch
from
0ae6e58
to
7cafad8
Compare
tremble
approved these changes
Oct 19, 2022
1 task
This was referenced May 22, 2024
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 22, 2024
s3_object - fix MemoryError when downloading large files SUMMARY fixes: #2107 The refactor in #1139 is triggering a full download of the file into memory when downloading files, this downloaded content was then being thrown away. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin
patchback bot
pushed a commit
that referenced
this pull request
May 22, 2024
s3_object - fix MemoryError when downloading large files SUMMARY fixes: #2107 The refactor in #1139 is triggering a full download of the file into memory when downloading files, this downloaded content was then being thrown away. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis Reviewed-by: Bikouo Aubin (cherry picked from commit 4829217)
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
May 29, 2024
[PR #2108/48292178 backport][stable-8] s3_object - fix MemoryError when downloading large files This is a backport of PR #2108 as merged into main (4829217). SUMMARY fixes: #2107 The refactor in #1139 is triggering a full download of the file into memory when downloading files, this downloaded content was then being thrown away. ISSUE TYPE Bugfix Pull Request COMPONENT NAME s3_object ADDITIONAL INFORMATION Reviewed-by: Mark Chappell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
get_s3_connectionis duplicated into moduless3_objectands3_object_info, the goal of this pull request is to move to a single place, reduce code complexity and increase coverageISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION