Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_ami: unit-test coverage #1159

Closed
wants to merge 1 commit into from
Closed

ec2_ami: unit-test coverage #1159

wants to merge 1 commit into from

Conversation

goneri
Copy link
Member

@goneri goneri commented Oct 11, 2022

Partial unit-test coverage of the ec2_ami.

@goneri goneri force-pushed the ec2_ami-unit-test-coverage_26080 branch from 2fea636 to fa4e294 Compare October 11, 2022 21:40
@ansibullbot
Copy link

@goneri: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information.

Here are the items we could not find in your description:

  • issue type

Please set the description of this pullrequest with this template:
https://raw.githubusercontent.com/ansible/ansible/devel/.github/PULL_REQUEST_TEMPLATE.md

click here for bot help

@ansibullbot ansibullbot added module module needs_info This issue requires further information. Please answer any outstanding questions needs_maintainer needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage new_plugin New plugin tests tests labels Oct 11, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 4m 26s
✔️ build-ansible-collection SUCCESS in 5m 45s
❌ ansible-test-sanity-aws-ansible-python38 FAILURE in 10m 49s
❌ ansible-test-sanity-aws-ansible-2.12-python38 FAILURE in 10m 38s
❌ ansible-test-sanity-aws-ansible-2.13-python38 FAILURE in 11m 36s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 5m 38s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 35s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 43s
✔️ cloud-tox-py3 SUCCESS in 3m 47s

@goneri goneri force-pushed the ec2_ami-unit-test-coverage_26080 branch from fa4e294 to 475fece Compare October 11, 2022 22:22
@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

✔️ ansible-galaxy-importer SUCCESS in 5m 40s
✔️ build-ansible-collection SUCCESS in 6m 09s
❌ ansible-test-sanity-aws-ansible-python38 FAILURE in 9m 21s
❌ ansible-test-sanity-aws-ansible-2.12-python38 FAILURE in 9m 54s
❌ ansible-test-sanity-aws-ansible-2.13-python38 FAILURE in 11m 01s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 54s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 05s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 33s
✔️ cloud-tox-py3 SUCCESS in 3m 44s

@goneri
ec2_ami: unit-test coverage
0d4a38b 
Partial unit-test coverage of the `ec2_ami`.
@goneri goneri force-pushed the ec2_ami-unit-test-coverage_26080 branch from 475fece to 0d4a38b Compare October 12, 2022 15:23
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 5m 15s
✔️ build-ansible-collection SUCCESS in 5m 23s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 36s
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 58s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 48s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 6m 34s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 7m 11s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 25s
✔️ cloud-tox-py3 SUCCESS in 4m 06s

@goneri goneri closed this Oct 12, 2022
saito-hideki pushed a commit to saito-hideki/amazon.aws that referenced this pull request Oct 18, 2022
@tremble @goneri
ec2_eip - remove wait_timeout (ansible-collections#1159)
ddf6313 
ec2_eip - remove wait_timeout

SUMMARY
Remove the wait_timeout option, it has always been ignored by the module
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip
ADDITIONAL INFORMATION
See also: ansible/ansible#64230

Reviewed-by: Markus Bergholz <git@osuv.de>

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@9460ca1
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble
ec2_eip - remove wait_timeout (ansible-collections#1159)
a266d7a 
ec2_eip - remove wait_timeout

SUMMARY
Remove the wait_timeout option, it has always been ignored by the module
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip
ADDITIONAL INFORMATION
See also: ansible/ansible#64230

Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Sep 18, 2023
@tremble @abikouo
ec2_eip - remove wait_timeout (ansible-collections#1159)
56b6235 
ec2_eip - remove wait_timeout

SUMMARY
Remove the wait_timeout option, it has always been ignored by the module
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip
ADDITIONAL INFORMATION
See also: ansible/ansible#64230

Reviewed-by: Markus Bergholz <git@osuv.de>
abikouo pushed a commit to abikouo/amazon.aws that referenced this pull request Oct 24, 2023
@tremble
ec2_eip - remove wait_timeout (ansible-collections#1159)
9460ca1 
ec2_eip - remove wait_timeout

SUMMARY
Remove the wait_timeout option, it has always been ignored by the module
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
ec2_eip
ADDITIONAL INFORMATION
See also: ansible/ansible#64230

Reviewed-by: Markus Bergholz <git@osuv.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
module module needs_info This issue requires further information. Please answer any outstanding questions needs_maintainer needs_template This issue/PR has an incomplete description. Please fill in the proposed template correctly needs_triage new_plugin New plugin tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goneri @ansibullbot