ec2_security_group - Move validation for rules into the arg_spec #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
tremble
changed the title
ansibullbot
added
community_review
feature
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
tremble
force-pushed
the
arg_spec/ec2_security_group/rules
branch
from
8b57ac0
to
6e927a2
Compare
1 task
tremble
commented
Oct 27, 2022
| @@ -1170,6 +1192,7 @@ def get_final_rules(client, module, security_group_rules, specified_rules, purge | |||
| rule[source_type] = [rule[source_type]] | |||
| format_rule[rule_key] = [{source_type: target} for target in rule[source_type]] | |||
| if rule.get('group_id') or rule.get('group_name'): | |||
| # XXX bug - doesn't cope with a list of ids/names | |||
There was a problem hiding this comment.
Existing bug - #1217 want to split proper solution as the diff code is gnarly
tremble
force-pushed
the
arg_spec/ec2_security_group/rules
branch
from
6e927a2
to
40037c3
Compare
ansibullbot
added
needs_maintainer
new_plugin
alinabuzachis
approved these changes
Oct 31, 2022
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
regate |
Backport to stable-5: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 896fe7a on top of patchback/backports/stable-5/896fe7aca231860ee3a573b11cb772f86836c4ea/pr-1214 Backporting merged PR #1214 into main
🤖 @patchback |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 2, 2022
ec2_security_group - refacter get_target_from_rule() SUMMARY refacter get_target_from_rule to bring down the complexity score Builds on top of #1214 ISSUE TYPE Feature Pull Request COMPONENT NAME ec2_security_group ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 8, 2022
Fix ec2_metadata_facts integration test SUMMARY With #1214 security_group now validates the rules its passed, requiring a "source" be passed (SG/CIDR). Previously it just dropped the rule on the floor. This has however broken the ec2_metadata_facts integration test ISSUE TYPE Bugfix Pull Request COMPONENT NAME ec2_metadata_facts ADDITIONAL INFORMATION Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The bulk of the current rule validation can be better handled by arg_spec parameter validation.
ISSUE TYPE
COMPONENT NAME
ec2_security_group
ADDITIONAL INFORMATION