Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rds_instance: support for gp3 #1266

Merged

Conversation

markuman
Copy link
Member

@markuman markuman commented Nov 14, 2022

SUMMARY

Fixes: #1254

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

rds_instance

ADDITIONAL INFORMATION

Required boto3 >= 1.26.0

@github-actions
Copy link

github-actions bot commented Nov 14, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot
Copy link

@ansibullbot ansibullbot added WIP Work in progress feature This issue/PR relates to a feature request integration tests/integration module module needs_triage plugins plugin (any type) tests tests labels Nov 14, 2022
@markuman
Copy link
Member Author

local ci passes here.
what do you think of the boto3_at_least check @goneri @tremble
what else should be tested?

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 29s
✔️ build-ansible-collection SUCCESS in 5m 05s
ansible-test-sanity-aws-ansible-python38 FAILURE in 10m 06s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 11s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 28s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 8m 28s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 12s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 6m 30s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 7m 05s
✔️ cloud-tox-py3 SUCCESS in 3m 15s
✔️ ansible-test-changelog SUCCESS in 2m 08s
✔️ ansible-test-splitter SUCCESS in 2m 30s
✔️ integration-amazon.aws-1 SUCCESS in 33m 26s
✔️ integration-amazon.aws-2 SUCCESS in 44m 24s
✔️ integration-amazon.aws-3 SUCCESS in 42m 55s
✔️ integration-amazon.aws-4 SUCCESS in 43m 54s
✔️ integration-amazon.aws-5 SUCCESS in 38m 29s
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 16s
✔️ build-ansible-collection SUCCESS in 5m 04s
ansible-test-sanity-aws-ansible-python38 FAILURE in 9m 08s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 9m 53s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 14s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 54s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 7m 19s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 5m 50s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 6m 20s
✔️ cloud-tox-py3 SUCCESS in 4m 01s
✔️ ansible-test-changelog SUCCESS in 2m 08s
✔️ ansible-test-splitter SUCCESS in 2m 52s
✔️ integration-amazon.aws-1 SUCCESS in 36m 26s
✔️ integration-amazon.aws-2 SUCCESS in 38m 58s
✔️ integration-amazon.aws-3 SUCCESS in 43m 18s
✔️ integration-amazon.aws-4 SUCCESS in 38m 44s
✔️ integration-amazon.aws-5 SUCCESS in 36m 00s
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

plugins/modules/rds_instance.py Outdated Show resolved Hide resolved
plugins/modules/rds_instance.py Outdated Show resolved Hide resolved
markuman and others added 2 commits December 1, 2022 19:25
Co-authored-by: Alina Buzachis <abuzachis@redhat.com>
Co-authored-by: Alina Buzachis <abuzachis@redhat.com>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

✔️ ansible-galaxy-importer SUCCESS in 4m 22s
✔️ build-ansible-collection SUCCESS in 7m 05s
ansible-test-sanity-aws-ansible-python38 FAILURE in 10m 26s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 27s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 24s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 08s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 16s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 9m 33s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 11m 07s
✔️ cloud-tox-py3 SUCCESS in 6m 34s
✔️ ansible-test-changelog SUCCESS in 2m 31s
✔️ ansible-test-splitter SUCCESS in 3m 53s
✔️ integration-amazon.aws-1 SUCCESS in 32m 48s
✔️ integration-amazon.aws-2 SUCCESS in 38m 52s
✔️ integration-amazon.aws-3 SUCCESS in 44m 47s
✔️ integration-amazon.aws-4 SUCCESS in 39m 54s
✔️ integration-amazon.aws-5 SUCCESS in 32m 38s
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@markuman markuman changed the title [WIP] rds_instance: support for gp3 rds_instance: support for gp3 Dec 1, 2022
@ansibullbot ansibullbot added community_review and removed WIP Work in progress labels Dec 1, 2022
@alinabuzachis alinabuzachis added the backport-5 PR should be backported to the stable-5 branch label Dec 14, 2022
@alinabuzachis alinabuzachis added the mergeit Merge the PR (SoftwareFactory) label Dec 14, 2022
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

✔️ ansible-galaxy-importer SUCCESS in 4m 17s
✔️ build-ansible-collection SUCCESS in 6m 25s
✔️ ansible-test-splitter SUCCESS in 2m 58s
✔️ integration-amazon.aws-1 SUCCESS in 32m 39s
✔️ integration-amazon.aws-2 SUCCESS in 42m 14s
✔️ integration-amazon.aws-3 SUCCESS in 47m 17s
✔️ integration-amazon.aws-4 SUCCESS in 35m 17s
✔️ integration-amazon.aws-5 SUCCESS in 35m 55s
⚠️ integration-amazon.aws-6 SKIPPED
⚠️ integration-amazon.aws-7 SKIPPED
⚠️ integration-amazon.aws-8 SKIPPED
⚠️ integration-amazon.aws-9 SKIPPED
⚠️ integration-amazon.aws-10 SKIPPED
⚠️ integration-amazon.aws-11 SKIPPED
⚠️ integration-amazon.aws-12 SKIPPED
⚠️ integration-amazon.aws-13 SKIPPED
⚠️ integration-amazon.aws-14 SKIPPED
⚠️ integration-amazon.aws-15 SKIPPED
⚠️ integration-amazon.aws-16 SKIPPED
⚠️ integration-amazon.aws-17 SKIPPED
⚠️ integration-amazon.aws-18 SKIPPED
⚠️ integration-amazon.aws-19 SKIPPED
⚠️ integration-amazon.aws-20 SKIPPED
⚠️ integration-amazon.aws-21 SKIPPED
⚠️ integration-amazon.aws-22 SKIPPED
⚠️ integration-community.aws-1 SKIPPED
⚠️ integration-community.aws-2 SKIPPED
⚠️ integration-community.aws-3 SKIPPED
⚠️ integration-community.aws-4 SKIPPED
⚠️ integration-community.aws-5 SKIPPED
⚠️ integration-community.aws-6 SKIPPED
⚠️ integration-community.aws-7 SKIPPED
⚠️ integration-community.aws-8 SKIPPED
⚠️ integration-community.aws-9 SKIPPED
⚠️ integration-community.aws-10 SKIPPED
⚠️ integration-community.aws-11 SKIPPED
⚠️ integration-community.aws-12 SKIPPED
⚠️ integration-community.aws-13 SKIPPED
⚠️ integration-community.aws-14 SKIPPED
⚠️ integration-community.aws-15 SKIPPED
⚠️ integration-community.aws-16 SKIPPED
⚠️ integration-community.aws-17 SKIPPED
⚠️ integration-community.aws-18 SKIPPED
⚠️ integration-community.aws-19 SKIPPED
⚠️ integration-community.aws-20 SKIPPED
⚠️ integration-community.aws-21 SKIPPED
⚠️ integration-community.aws-22 SKIPPED

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit e56003e into ansible-collections:main Dec 14, 2022
@patchback
Copy link

patchback bot commented Dec 14, 2022

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/e56003e341f9ba37ff5e7aa77ca44f228155ec6d/pr-1266

Backported as #1298

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 14, 2022
rds_instance: support for gp3

SUMMARY
Fixes: #1254
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION
Required boto3 >= 1.26.0

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
(cherry picked from commit e56003e)
tremble pushed a commit that referenced this pull request Jan 10, 2023
rds_instance: support for gp3

SUMMARY
Fixes: #1254
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION
Required boto3 >= 1.26.0

Reviewed-by: Alina Buzachis <None>
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
(cherry picked from commit e56003e)
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Jan 10, 2023
[PR #1266/e56003e3 backport][stable-5] rds_instance: support for gp3

This is a backport of PR #1266 as merged into main (e56003e).
SUMMARY
Fixes: #1254
ISSUE TYPE

Feature Pull Request

COMPONENT NAME
rds_instance
ADDITIONAL INFORMATION
Required boto3 >= 1.26.0

Reviewed-by: Mark Chappell <None>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-5 PR should be backported to the stable-5 branch community_review feature This issue/PR relates to a feature request integration tests/integration mergeit Merge the PR (SoftwareFactory) module module plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rds_instance: gp3 support
5 participants