Sanity fix for changelog fragment #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 4m 07s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 4m 20s |
softwarefactory-project-zuul bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
…1253) route53_health_check: Fix "Name" tag key removal idempotentcy issue SUMMARY Depends-On: #1280 Fixes #1188 When using health_check_name as unique identifier (setting use_unique_names: True and providing a health_check_name) and health_check tags are set, Current logic for adding name to a health_check causes an issue when rerunning the create/update task. While ideally it should be idempotent, it removes the 'Name' tag (used for health_check_name) causing removal of health check name. ISSUE TYPE Bugfix Pull Request COMPONENT NAME route53_health_check ADDITIONAL INFORMATION To test, run the following sample playbook task twice Expected output: Health check name should not disapper (i.e. 'Name' tag should not get removed on rerun) --- - hosts: localhost gather_facts: False tasks: - name: Create a health-check amazon.aws.route53_health_check: health_check_name: my-test-hc use_unique_names: true fqdn: my-test-xyz.com type: HTTPS resource_path: / request_interval: 30 failure_threshold: 3 tags: Service: my-service Owner: my-test-xyz Lifecycle: dev Reviewed-by: Mark Chappell <None> Reviewed-by: GomathiselviS <None> Reviewed-by: Mandar Kulkarni <mandar242@gmail.com> Reviewed-by: Mike Graves <mgraves@redhat.com> Reviewed-by: Gonéri Le Bouder <goneri@lebouder.net> Reviewed-by: Alina Buzachis <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Sanity fix for changelog fragment of #1275
The changelogs fragment is causing CI failure for sanity tests for other PRs such as #1253
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION