Add 'base' connection plugin code #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
community_review
feature
tremble
force-pushed
the
refactor/connection_plugin
branch
from
2daaf89
to
2e23899
Compare
tremble
force-pushed
the
refactor/connection_plugin
branch
from
2e23899
to
c29e8a9
Compare
tremble
force-pushed
the
refactor/connection_plugin
branch
from
c29e8a9
to
bc75475
Compare
This comment was marked as outdated.
This comment was marked as outdated.
tremble
force-pushed
the
refactor/connection_plugin
branch
from
bc75475
to
7514a46
Compare
This comment was marked as outdated.
This comment was marked as outdated.
|
This change depends on a change that failed to merge. |
|
recheck |
tremble
force-pushed
the
refactor/connection_plugin
branch
from
e797931
to
7514a46
Compare
|
recheck |
alinabuzachis
approved these changes
Jan 19, 2023
markuman
approved these changes
Jan 19, 2023
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Jan 19, 2023
aws_ssm - Refactor boto3 client initialization Depends-On: ansible/ansible-zuul-jobs#1748 SUMMARY Move the boto3 client initialization into a consistent point (rather than initializing them on the fly) ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION In preparation for further refactoring and using ansible-collections/amazon.aws#1340 Reviewed-by: Markus Bergholz <git@osuv.de>
patchback bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Jan 20, 2023
aws_ssm - Refactor boto3 client initialization Depends-On: ansible/ansible-zuul-jobs#1748 SUMMARY Move the boto3 client initialization into a consistent point (rather than initializing them on the fly) ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION In preparation for further refactoring and using ansible-collections/amazon.aws#1340 Reviewed-by: Markus Bergholz <git@osuv.de> (cherry picked from commit 5759afa)
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.aws
that referenced
this pull request
Jan 20, 2023
[PR #1663/5759afa1 backport][stable-5] aws_ssm - Refactor boto3 client initialization This is a backport of PR #1663 as merged into main (5759afa). Depends-On: ansible/ansible-zuul-jobs#1748 SUMMARY Move the boto3 client initialization into a consistent point (rather than initializing them on the fly) ISSUE TYPE Feature Pull Request COMPONENT NAME aws_ssm ADDITIONAL INFORMATION In preparation for further refactoring and using ansible-collections/amazon.aws#1340 Reviewed-by: Mark Chappell <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: ansible/ansible-zuul-jobs#1748
SUMMARY
Adds a plugin_utils.connection.AWSConnectionBase to support future work on aws_ssm plugin.
ISSUE TYPE
COMPONENT NAME
plugin_utils/connection.py
ADDITIONAL INFORMATION