Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ec2_spot_instance: add parameter to enable terminating spot instances when cancelling request #1402

Merged
merged 8 commits into from
Mar 8, 2023
Merged

ec2_spot_instance: add parameter to enable terminating spot instances when cancelling request #1402

merged 8 commits into from
Mar 8, 2023

Conversation

mandar242
Copy link
Contributor

@mandar242 mandar242 commented Mar 2, 2023 •
edited
Loading

SUMMARY

This PR adds a new parameter terminate_instances (true | false) to enable terminating spot instances when cancelling request.
Can be used only when state=absent.

Fixes #1360

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ec2_spot_instance

ADDITIONAL INFORMATION

@github-actions
Copy link

github-actions bot commented Mar 2, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/4592fba52d85429db42d0afb9c7c9186

✔️ ansible-galaxy-importer SUCCESS in 4m 03s
✔️ build-ansible-collection SUCCESS in 12m 20s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 07s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 8m 41s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 04s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 9m 16s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 15m 58s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 52s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 10m 36s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 49s
✔️ cloud-tox-py3 SUCCESS in 7m 41s
✔️ ansible-test-changelog SUCCESS in 4m 17s
✔️ ansible-test-splitter SUCCESS in 4m 36s
✔️ integration-amazon.aws-1 SUCCESS in 14m 48s
Skipped 43 jobs

@mandar242 mandar242 requested a review from abikouo March 3, 2023 22:07
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/6e88ccfaa0dd47e08ff9573e417e0e10

✔️ ansible-galaxy-importer SUCCESS in 4m 08s
✔️ build-ansible-collection SUCCESS in 12m 39s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 57s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 20s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 10m 21s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 31s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 8m 46s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 8m 32s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 8m 52s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 28s
✔️ cloud-tox-py3 SUCCESS in 6m 44s
✔️ ansible-test-changelog SUCCESS in 4m 17s
✔️ ansible-test-splitter SUCCESS in 4m 41s
✔️ integration-amazon.aws-1 SUCCESS in 12m 29s
Skipped 43 jobs

@alinabuzachis alinabuzachis added the backport-5 PR should be backported to the stable-5 branch label Mar 7, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/26e82fc1c01f4b0e992a7a95c57b23f1

✔️ ansible-galaxy-importer SUCCESS in 4m 03s
✔️ build-ansible-collection SUCCESS in 23m 14s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 10m 06s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 07s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 55s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 09s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 10m 19s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 9m 31s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 9m 24s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 9m 55s
✔️ cloud-tox-py3 SUCCESS in 6m 22s
✔️ ansible-test-changelog SUCCESS in 8m 40s
✔️ ansible-test-splitter SUCCESS in 9m 17s
✔️ integration-amazon.aws-1 SUCCESS in 13m 00s
Skipped 43 jobs

@mandar242 mandar242 added the mergeit Merge the PR (SoftwareFactory) label Mar 8, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/a971dd7af2d34b93bc922f2f16ff17a1

✔️ ansible-galaxy-importer SUCCESS in 4m 39s
✔️ build-ansible-collection SUCCESS in 25m 07s
✔️ ansible-test-splitter SUCCESS in 10m 06s
✔️ integration-amazon.aws-1 SUCCESS in 20m 46s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit aa86240 into ansible-collections:main Mar 8, 2023
@patchback
Copy link

patchback bot commented Mar 8, 2023 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/aa86240df748e12ed145910ad2927296c14dad66/pr-1402

Backported as #1418

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 8, 2023
@mandar242 @patchback
ec2_spot_instance: add parameter to enable terminating spot instances…
f8ad13f 
… when cancelling request (#1402)

ec2_spot_instance: add parameter to enable terminating spot instances when cancelling request

SUMMARY

This PR adds a new parameter terminate_instances (true | false) to enable terminating spot instances when cancelling request.
Can be used only when state=absent.

Fixes #1360
ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ec2_spot_instance
ADDITIONAL INFORMATION

Reviewed-by: Bikouo Aubin
Reviewed-by: Mandar Kulkarni <mandar242@gmail.com>
Reviewed-by: Alina Buzachis
Reviewed-by: Mark Chappell
(cherry picked from commit aa86240)
@patchback patchback bot mentioned this pull request Mar 8, 2023
Merged
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Mar 17, 2023
@patchback
ec2_spot_instance: add parameter to enable terminating spot instances…
5406b67 
… when cancelling request (#1402) (#1418)

[PR #1402/aa86240d backport][stable-5] ec2_spot_instance: add parameter to enable terminating spot instances when cancelling request

This is a backport of PR #1402 as merged into main (aa86240).
SUMMARY

This PR adds a new parameter terminate_instances (true | false) to enable terminating spot instances when cancelling request.
Can be used only when state=absent.

Fixes #1360
ISSUE TYPE


Feature Pull Request

COMPONENT NAME

ec2_spot_instance
ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
@mandar242 mandar242 deleted the terminate_spot_instances branch May 9, 2023 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremble tremble tremble left review comments

@abikouo abikouo abikouo approved these changes

@alinabuzachis alinabuzachis alinabuzachis approved these changes

Assignees
No one assigned
Labels
backport-5 PR should be backported to the stable-5 branch mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AWS: Cancelling EC2 Spot Request
4 participants
@mandar242 @tremble @alinabuzachis @abikouo