Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't consider prop 'StateTransitionedTimestamp' in change detection #1440

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Don't consider prop 'StateTransitionedTimestamp' in change detection #1440

merged 3 commits into from
Mar 28, 2023

Conversation

davidovp
Copy link
Contributor

SUMMARY

Remove property 'StateTransitionedTimestamp' from the list of props when determining if an alarm has changed and needs to be create/updated.

Fixes #1439

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

cloudwatch-metric-alarm

ADDITIONAL INFORMATION

See issue #1439 for additional details.

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.
https://ansible.softwarefactory-project.io/zuul/buildset/142075d0d73343899f448710180787e5

✔️ ansible-galaxy-importer SUCCESS in 4m 15s
✔️ build-ansible-collection SUCCESS in 12m 19s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 9m 15s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 10m 26s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 9m 54s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 8m 25s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 29s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 10m 04s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 9m 02s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 11m 47s
✔️ cloud-tox-py3 SUCCESS in 7m 39s
❌ ansible-test-changelog FAILURE in 4m 16s
✔️ ansible-test-splitter SUCCESS in 4m 42s
✔️ integration-amazon.aws-1 SUCCESS in 9m 03s
✔️ integration-community.aws-1 SUCCESS in 5m 17s
Skipped 42 jobs

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/0dfbbd5cfd7a4b1399e40d641a2fd137

✔️ ansible-galaxy-importer SUCCESS in 4m 30s
✔️ build-ansible-collection SUCCESS in 12m 30s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 8m 26s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 11m 34s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 8m 40s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 59s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 9m 49s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 11m 36s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 10m 24s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 13m 04s
✔️ cloud-tox-py3 SUCCESS in 7m 19s
✔️ ansible-test-changelog SUCCESS in 4m 12s
✔️ ansible-test-splitter SUCCESS in 4m 50s
✔️ integration-amazon.aws-1 SUCCESS in 9m 37s
✔️ integration-community.aws-1 SUCCESS in 5m 22s
Skipped 42 jobs

tremble
tremble approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@tremble tremble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the change looks good. However, please there's a minor tweak needed to the formatting of the changelog.

changelogs/fragments/1440-cloudwatch_metric_alarm-fix-change-detection.yml Outdated Show resolved Hide resolved
@davidovp @tremble
Update changelogs/fragments/1440-cloudwatch_metric_alarm-fix-change-d…
13e394a 
…etection.yml

Co-authored-by: Mark Chappell <mchappel@redhat.com>
@github-actions
Copy link

github-actions bot commented Mar 27, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/2451195a4f434824a5971f1af40b931b

✔️ ansible-galaxy-importer SUCCESS in 4m 19s
✔️ build-ansible-collection SUCCESS in 12m 58s
✔️ ansible-test-sanity-aws-ansible-python38 SUCCESS in 12m 23s (non-voting)
✔️ ansible-test-sanity-aws-ansible-2.12-python38 SUCCESS in 11m 05s
✔️ ansible-test-sanity-aws-ansible-2.13-python38 SUCCESS in 11m 02s
✔️ ansible-test-sanity-aws-ansible-2.14 SUCCESS in 10m 04s
✔️ ansible-test-units-amazon-aws-python36 SUCCESS in 10m 23s
✔️ ansible-test-units-amazon-aws-python38 SUCCESS in 10m 23s
✔️ ansible-test-units-amazon-aws-python39 SUCCESS in 10m 37s
✔️ ansible-test-units-amazon-aws-python310 SUCCESS in 11m 47s
✔️ cloud-tox-py3 SUCCESS in 8m 08s
✔️ ansible-test-changelog SUCCESS in 4m 28s
✔️ ansible-test-splitter SUCCESS in 4m 55s
✔️ integration-amazon.aws-1 SUCCESS in 9m 42s
Skipped 43 jobs

@tremble tremble added the mergeit Merge the PR (SoftwareFactory) label Mar 28, 2023
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/c5272bdc9d944f06b19e973a62b08ae3

✔️ ansible-galaxy-importer SUCCESS in 4m 18s
✔️ build-ansible-collection SUCCESS in 12m 56s
✔️ ansible-test-splitter SUCCESS in 5m 07s
✔️ integration-amazon.aws-1 SUCCESS in 9m 59s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 8acb076 into ansible-collections:main Mar 28, 2023
alinabuzachis pushed a commit to alinabuzachis/amazon.aws that referenced this pull request Apr 26, 2023
@davidovp @alinabuzachis
Don't consider prop 'StateTransitionedTimestamp' in change detection (a…
6c2d244 
…nsible-collections#1440)

Don't consider prop 'StateTransitionedTimestamp' in change detection

SUMMARY

Remove property 'StateTransitionedTimestamp' from the list of props when determining if an alarm has changed and needs to be create/updated.

Fixes ansible-collections#1439
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
cloudwatch-metric-alarm
ADDITIONAL INFORMATION
See issue ansible-collections#1439 for additional details.

Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
softwarefactory-project-zuul bot pushed a commit that referenced this pull request Apr 26, 2023
@alinabuzachis
Don't consider prop 'StateTransitionedTimestamp' in change detection (#…
aa6da23 
…1440) (#1480)

[manual backport stable-5] Don't consider prop 'StateTransitionedTimestamp' in change detection (#1440)

SUMMARY
Remove property 'StateTransitionedTimestamp' from the list of props when determining if an alarm has changed and needs to be create/updated.
Fixes #1439
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
cloudwatch-metric-alarm
ADDITIONAL INFORMATION
See issue #1439 for additional details.
Reviewed-by: Mark Chappell
Reviewed-by: Alina Buzachis
SUMMARY


ISSUE TYPE


Bugfix Pull Request
Docs Pull Request
Feature Pull Request
New Module Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

Reviewed-by: Mark Chappell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@tremble tremble tremble approved these changes

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cloudwatch_metric_alarm - Existing alarms always report 'changed' even when no changes have been made
3 participants
@davidovp @tremble @alinabuzachis